Hi Hoang, No issue , for now we can push this for to over come current bug that you are facing .
We can address all the LONG DN related issue including Section ID length. ============================================================================================ Object Class : Table 2 DN Formats for Objects of Checkpoint Service Classes (SAI-AIS-CKPT-B.02.02 spec) 1) SaCkptCheckpoint -- "safCkpt=...,* " 2) SaCkptReplica -- "safReplica=...,safCkpt=...,* " ============================================================================================ So ACK form me not tested. -AVM On 6/14/2016 2:40 PM, Vo Minh Hoang wrote: > Dear Mahesh, > > Thank you very much for your information. > It seem I have lack of information when receiving this ticket from Nhat > Pham. > We will consider more about this. > > Sincerely, > Hoang > > -----Original Message----- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Tuesday, June 14, 2016 3:55 PM > To: Hoang Vo <hoang.m...@dektech.com.au> > Cc: opensaf-devel@lists.sourceforge.net > Subject: Re: [PATCH 1 of 1] cpnd: To reject creating section which has id > length longer than MAX_SEC_ID_LEN [#1667] > > Hi Hoang Vo, > > This patch is already published by Nhat Pham , and > > it is under review, I also provided few comments ( attached ) , please > check. > > -AVM > > > On 6/14/2016 1:48 PM, Hoang Vo wrote: >> osaf/services/saf/cpsv/cpnd/cpnd_evt.c | 11 +++++++++++ >> 1 files changed, 11 insertions(+), 0 deletions(-) >> >> >> When a section with id size greater than MAX_SEC_ID_LEN [50], the cpnd > restarts with core dump. >> This fixing validates id size before creating section. >> >> diff --git a/osaf/services/saf/cpsv/cpnd/cpnd_evt.c >> b/osaf/services/saf/cpsv/cpnd/cpnd_evt.c >> --- a/osaf/services/saf/cpsv/cpnd/cpnd_evt.c >> +++ b/osaf/services/saf/cpsv/cpnd/cpnd_evt.c >> @@ -2167,6 +2167,7 @@ static uint32_t cpnd_evt_proc_ckpt_sect_ >> CPSV_CKPT_DATA *ckpt_data = NULL; >> SaTimeT now, duration; >> int64_t time_stamp, giga_sec, result; >> + uint16_t sec_id_len = >> +evt->info.sec_creatReq.sec_attri.sectionId->idLen; >> >> TRACE_ENTER(); >> memset(&send_evt, '\0', sizeof(CPSV_EVT)); @@ -2205,6 +2206,16 @@ >> static uint32_t cpnd_evt_proc_ckpt_sect_ >> TRACE_4("cpnd ckpt sect create failed for > ckpt_id:%llx,return value:%d",evt->info.sec_creatReq.ckpt_id, > SA_AIS_ERR_INVALID_PARAM); >> goto agent_rsp; >> } >> + >> + if (sec_id_len >= MAX_SEC_ID_LEN) { >> + send_evt.type = CPSV_EVT_TYPE_CPA; >> + send_evt.info.cpa.type = CPA_EVT_ND2A_SEC_CREATE_RSP; >> + send_evt.info.cpa.info.sec_creat_rsp.error = > SA_AIS_ERR_INVALID_PARAM; >> + LOG_NO("cpnd ckpt sect create failed for ckpt_id:%llx,return > value:%d - sec_id_len:%d over supported limit %d", >> + evt->info.sec_creatReq.ckpt_id, > SA_AIS_ERR_INVALID_PARAM, sec_id_len, MAX_SEC_ID_LEN); >> + goto agent_rsp; >> + } >> + >> if (evt->info.sec_creatReq.sec_attri.sectionId->id == NULL && >> evt->info.sec_creatReq.sec_attri.sectionId->idLen == 0) { >> if (cp_node->create_attrib.maxSections > 1) { > ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohomanageengine _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
