Summary: log: support DNs longer than 255 bytes [#1315]
Review request for Trac Ticket(s): #1315
Peer Reviewer(s): Mahesh, Lennart
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests y
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Refer to the README file on the ticket for more info on changes of following
patches
changeset f3cefb4d3fea8f2dbd1887b9a81654254c64069f
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Thu, 09 Jun 2016 14:14:32 +0700
log: add one new option -f to saflogger tool [#1315]
With app stream, saflogger used app stream DN as logFileName. With Long
DN,
the app stream DN could be longer than 255 characters in length.
This patch provides one new option -f <filename>. This option is only
applicable for app stream.
changeset b90e3d5141e299056193d7dc2b50919bb8b446c9
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Fri, 10 Jun 2016 18:47:15 +0700
log: update LOG agent to support Long DN & RDN [#1315]
Replace all internal SaNameT by C string and make log agent support
long DN,
but keep backward compatible.
changeset f91398fa22cbfc5c3ddc508a913e3a2ea4901fd6
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Thu, 23 Jun 2016 13:24:41 +0700
log: update logsv to support long DN [#1315]
Major change overview: 1) Replace all internal SaNameT with C/C++
strings 2)
Remove NCS_PATRICIA_TREE used to hold stream DNs, Using the existing
database `stream_array` instead. 3) Change a bit in
`checkFieldSize()/lgs_fmt`, check `numOfDigits` agains number of digits
of
the constant SA_LOG_MAX_RECORD_SIZE
changeset 8a4ec05f071876255bbea7fe0ad012bff5b6345c
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Sat, 18 Jun 2016 14:09:15 +0700
log: create test cases and update logtest for long DN [#1315]
Major changes: 1) Add new test suite #13 for long DN test
(tet_log_longDN.c
file) 2) Do re-processing for old SaNameT 3) Disable test cases that
checked
DN limited to 256 bytes
Added Files:
------------
tests/logsv/tet_log_longDN.c
Complete diffstat:
------------------
osaf/libs/agents/saf/lga/Makefile.am | 1 +
osaf/libs/agents/saf/lga/lga.h | 5 +-
osaf/libs/agents/saf/lga/lga_api.c | 110 ++++++-------
osaf/libs/agents/saf/lga/lga_mds.c | 168 +++++++++++++-------
osaf/libs/agents/saf/lga/lga_state.c | 7 +-
osaf/libs/agents/saf/lga/lga_util.c | 49 +++++-
osaf/libs/saf/libSaLog/Makefile.am | 1 +
osaf/services/saf/logsv/lgs/Makefile.am | 1 +
osaf/services/saf/logsv/lgs/lgs.h | 4 +-
osaf/services/saf/logsv/lgs/lgs_amf.cc | 14 +-
osaf/services/saf/logsv/lgs/lgs_config.cc | 30 +--
osaf/services/saf/logsv/lgs/lgs_evt.cc | 77 +++++---
osaf/services/saf/logsv/lgs/lgs_filehdl.cc | 12 +-
osaf/services/saf/logsv/lgs/lgs_fmt.cc | 41 ++--
osaf/services/saf/logsv/lgs/lgs_imm.cc | 256
+++++++++++++++----------------
osaf/services/saf/logsv/lgs/lgs_imm_gcfg.cc | 12 +-
osaf/services/saf/logsv/lgs/lgs_main.cc | 7 +-
osaf/services/saf/logsv/lgs/lgs_mbcsv.cc | 74 +++++---
osaf/services/saf/logsv/lgs/lgs_mds.cc | 296
+++++++++++++++++++++++--------------
osaf/services/saf/logsv/lgs/lgs_recov.cc | 44 ++---
osaf/services/saf/logsv/lgs/lgs_recov.h | 8 +-
osaf/services/saf/logsv/lgs/lgs_stream.cc | 322
+++++++++++++---------------------------
osaf/services/saf/logsv/lgs/lgs_stream.h | 18 +-
osaf/services/saf/logsv/lgs/lgs_util.cc | 25 +++-
osaf/services/saf/logsv/lgs/lgs_util.h | 2 +
osaf/tools/saflog/saflogger/Makefile.am | 1 +
osaf/tools/saflog/saflogger/saf_logger.c | 90 +++++++++--
tests/logsv/Makefile.am | 4 +-
tests/logsv/logtest.c | 132 ++++++----------
tests/logsv/tet_LogOiOps.c | 2 +-
tests/logsv/tet_Log_recov.c | 17 +-
tests/logsv/tet_log_longDN.c | 1226
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
tests/logsv/tet_log_runtime_cfgobj.c | 9 +-
tests/logsv/tet_saLogStreamOpen_2.c | 53 ++---
tests/logsv/tet_saLogWriteLogAsync.c | 8 +-
35 files changed, 2229 insertions(+), 897 deletions(-)
Testing Commands:
-----------------
Run test suite #13
Testing, Expected Results:
--------------------------
All tests PASS
Conditions of Submission:
-------------------------
Get ack from peer reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
