Ack, code review only.

Thanks,
Praveen

On 07-Apr-16 6:53 AM, Minh Hon Chau wrote:
>  osaf/services/saf/amf/amfd/ndproc.cc |  2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> While amfd is performing sync with all amfnd(s) after headless, there should 
> be
> component/su error (for instance a restart error) occuring during sync period.
> Amfnd(s) sends data_update msg(s) to increase the error counter. This 
> data_update(s)
> will be ignored at amfd since amfnd is still absent due to on-going sync. 
> Amfnd(s)
> will resend these update messages after sync completes.
>
> Patch lower severity of logging for data_update while syncing, it should be 
> more
> likely a warning than an error.
>
> diff --git a/osaf/services/saf/amf/amfd/ndproc.cc 
> b/osaf/services/saf/amf/amfd/ndproc.cc
> --- a/osaf/services/saf/amf/amfd/ndproc.cc
> +++ b/osaf/services/saf/amf/amfd/ndproc.cc
> @@ -810,7 +810,7 @@ void avd_data_update_req_evh(AVD_CL_CB *
>       }
>
>       if ((node->node_state == AVD_AVND_STATE_ABSENT) || (node->node_state == 
> AVD_AVND_STATE_GO_DOWN)) {
> -             LOG_ER("%s: node %x, receive msg_id(%u) in invalid node state 
> %u",
> +             LOG_WA("%s: node %x, receive msg_id(%u) in invalid node state 
> %u",
>                       __FUNCTION__, node->node_info.nodeId,
>                       n2d_msg->msg_info.n2d_data_req.msg_id, 
> node->node_state);
>
>

------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to