Summary: AMF: Extend escalation support during headless [#1902] Review request for Trac Ticket(s): 1902 Peer Reviewer(s): AMF maintainers Pull request to: Gary Affected branch(es): default, 5.0 Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset 2128f4b5375546670ac2c089fe92814abdb2f4a0 Author: Minh Hon Chau <[email protected]> Date: Thu, 07 Jul 2016 16:31:43 +1000 AMFND: Extend escalation support during headless at node director [#1902] If any escalation requires a failover/switchover during headless, amfnd currently reboot the node. This impacts on other healthy application regardless reboot configuration. For example, if saAmfNodeAutoRepair is disabled, that means there will not be a reboot if nodeFailover/Switchover The patch removes the current reboot after failover/switchover is escalated as of now. The purpose of the patch is to keep AMFND's behaviour staying close to non-headless as much as possible. However, if componentFailover of NPI SU is reached, it would be a suFailover orchestrated by AFMD. But AMFD is not present, AMFND has to perform cleanup part as of suFailover due to faulty component. changeset e0f57bc48a35eea1e11c473da9a3d187f3e5522b Author: Minh Hon Chau <[email protected]> Date: Thu, 07 Jul 2016 16:31:43 +1000 AMFD: Extend escalation support during headless at director [#1902] This patch comes together with "AMFND: Extend escalation support during headless at node director [#1902]" to complete the escalation when SC comes back. Please note that this patch can only help to complete escalation during headless, it does not include a recovery. If AMFND reaches nodeFailover/nodeSwitchover escalation, it needs information of saAmfNodeAutoRepair which has been kept at director to make a decision of reboot. Moreover, to uniform with nodeFailFast due to InstantiationFailed/TerminationFailed, the reboot due to nodeFailover/nodeSwitchover will be decided by AMFD after headless. The patch bufferes oper_state messages during headless and resends them after SC comes back. The reason is that AMFD is not able aware of any escalation which has been reached during headless, AMFD needs by somehow AMFND re-inform the errors escalation. Thus oper_state msg is reused. Exceptionally, if PI componentFailover has reached after headless, this patch can continue the componentFailover recovery. Other suFailover/nodeFailover/nodeSwitchover recovery won't succeed, and #1725 will complete these recovery. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/sgproc.cc | 3 +- osaf/services/saf/amf/amfnd/di.cc | 51 +++++++++++++++++++++++-------- osaf/services/saf/amf/amfnd/err.cc | 91 ++++++++++---------------------------------------------- osaf/services/saf/amf/amfnd/susm.cc | 7 +++- 4 files changed, 62 insertions(+), 90 deletions(-) Testing Commands: ----------------- Rerun tests of escalation Testing, Expected Results: -------------------------- - Perform error report/escalation that reaches failover/swithcover during headless - Escalation of failover/switchover will be completed after headless per configuration - No recovery is expected, except componentFailover Conditions of Submission: ------------------------- ack from reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San Francisco, CA to explore cutting-edge tech and listen to tech luminaries present their vision of the future. This family event has something for everyone, including kids. Get more information and register today. http://sdm.link/attshape _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
