Summary: AMFD: Initialize CLM, NTF handle in thread [#1828] V2
Review request for Trac Ticket(s): 1828
Peer Reviewer(s): AMF maintainers
Pull request to: Gary
Affected branch(es): 5.0, default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
In this V2, amfd does CLM/NTF init when amfd get active/standby role
changeset 5ae93844c6a37b4546468635a92d3c70d85aec82
Author: Minh Hon Chau <minh.c...@dektech.com.au>
Date: Wed, 27 Jul 2016 18:00:25 +1000
AMFD: Initialize CLM, NTF handle in thread [#1828] V2
In new controller reallocation scenario with roaming sc feature, if
immnd
dies in the node becoming active, the circular dependencies among
Opensaf
services appear, which leads eventually to a reboot.
The dependencies are: .clmd can not use IMM services since immnd dies
.immnd
needs restarted by amfnd .amfnd is hanging since amfnd is calling CLM
services .amfd is also hanging since amfd is calling CLM and NTF
services
.ntfd is hanging due to logd's dependencies on IMM
The problem could be solved if: . amfd initializes NTF, CLM handle in
thread
in initialization phase . amfnd initializes CLM in thread if amfnd
receives
clm bad handle
Since amfnd has already initialized CLM in thread up on receiving clm
bad
handle. This patch does initialze CLM, NTF in thread at amfd side. Also,
threading initialization in this patch can be refactored later by
utilizing
the support of #1609
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/clm.cc | 103
++++++++++++++++++++++++++++++++++++++++++++-------
osaf/services/saf/amf/amfd/include/cb.h | 7 ++-
osaf/services/saf/amf/amfd/include/clm.h | 6 ++-
osaf/services/saf/amf/amfd/include/ntf.h | 3 +
osaf/services/saf/amf/amfd/main.cc | 17 +++-----
osaf/services/saf/amf/amfd/ntf.cc | 85
++++++++++++++++++++++++++++++++++++++++++
osaf/services/saf/amf/amfd/role.cc | 24 ++++++-----
7 files changed, 205 insertions(+), 40 deletions(-)
Testing Commands:
-----------------
<<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>>
Testing, Expected Results:
--------------------------
<<PASTE COMMAND OUTPUTS / TEST RESULTS>>
Conditions of Submission:
-------------------------
ack from reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
