Hi Praveen On 1/08/2016 4:29 PM, praveen malviya wrote: > Hi Gary, Long, > > Some comments/observations: > -In AMFD saAisNameBorrow() is used in logging and AMFND uses > osaf_extended_name_borrow(). > For osaf_extended_name_borrow() note in osaf_extended_name.h says it > is intended for mainly agent libraries. But middle-ware services > always use core libs. At the same time saAisNameBorrow(), I think, is > for application. > any reason of using them this way and what is the recommended way? I think I used both styles in amfd. I think we can change saAisNameXX to osaf_extended_name_XX just before pushing, to make it consistent with the rest of the OpenSAF services. > -I think, one case may arrive from upgrade perspective. > Suppose any application (say amf_demo app) is running without enabling > long dn and a csi, with its RDn greater than 256, is added dynamically > (long dn enabled in IMM). In this case AMFD will assign this csi to > the running component. Component will not be able to read the CSI and > may crash. > This is related to invocation of CSI_SET callback but same will be > valid for PG tracking also. There may be other cases also. > Even truncation will not work in this case. > - While running some tests observed crashes in amfnd and amfd. > I will update #1642 with bt information. Minh will answer this bit.
Thanks Gary ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
