Hi Neel,
Reviewed and tested the patches.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
--------------------------------------------------------------------------------
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Wednesday, July 27, 2016 3:31PM
To: Zoran Milinkovic, Hung Nguyen
zoran.milinko...@ericsson.com, hung.d.ngu...@dektech.com.au
Cc: Opensaf-devel
opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 5] Review Request for imm:Hardcoded limits are made into
config parameters [#195]
Summary: Hardcoded limits are added as config parameters [#195]
Review request for Trac Ticket(s):195
Peer Reviewer(s): Zoran, Hung
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset bd980ca7528061b3b8dac255d15b808871178526
Author: Neelakanta Reddy
Date: Wed, 27 Jul 2016 13:48:35 +0530
imm: Remove the IMM limits checking in encoding and decoding [#195]
changeset f389fb5fc59a506fb4342ccd44f333c3b6296e8b
Author: Neelakanta Reddy
Date: Wed, 27 Jul 2016 13:49:25 +0530
imm: Added new attributes to imm config class [#195]
changeset 157b4ec00ae677a693985353f6916195b2cfbcba
Author: Neelakanta Reddy
Date: Wed, 27 Jul 2016 13:51:21 +0530
imm: Checking of Imm limits [#195]
changeset e95dcbb8b133eab87d7fc98346a94b29f01a8245
Author: Neelakanta Reddy
Date: Wed, 27 Jul 2016 13:53:20 +0530
imm: Added the updated OpensafImm class [#195]
changeset 1059ddcaa88c7af100ab7f715894bda882802bd9
Author: Neelakanta Reddy
Date: Wed, 27 Jul 2016 13:53:50 +0530
imm: updated README [#195]
Complete diffstat:
------------------
osaf/libs/common/immsv/immsv_evt.c | 69
++++---------------------------
osaf/libs/common/immsv/include/immsv_api.h | 9 ++++
osaf/services/saf/immsv/README | 43 +++++++++++++++++++
osaf/services/saf/immsv/immloadd/imm_loader.cc | 28 +++++++++++-
osaf/services/saf/immsv/immnd/ImmModel.cc | 322
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
osaf/services/saf/immsv/immnd/ImmModel.hh | 5 +-
tests/immsv/management/test_saImmOmAccessorGet_2.c | 2 +-
7 files changed, 412 insertions(+), 66 deletions(-)
Testing Commands:
-----------------
Test the maximum limits for each attribute.
Modify the attributes to a new value and test
Test while upgrading the node from 5.0 to default
Testing, Expected Results:
--------------------------
ERR_NO_RESOURCE or ERR_BAD_OPERATION is returned based on
the verification against the results.
Conditions of Submission:
-------------------------
Ack from reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
