Summary: cpsv: To update checkpoint user number for each node [#1669] V4
Review request for Trac Ticket(s): 1669
Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com
Pull request to: mahesh.va...@oracle.com; anders.wid...@ericsson.com
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset a3c955aed8fc6edab76a536b97f66369d305fc89
Author: Hoang Vo <hoang.m...@dektech.com.au>
Date: Wed, 03 Aug 2016 17:20:08 +0700
cpsv: To update checkpoint user number for each node [#1669] V4
Problem:
------- The saCkptCheckpointNumOpeners is not updated when a node which
has a
checkpoint client restarts.
Solution:
-------- Currently CPD doesn't store number of user on each node. This
patch
updates CPD to update information about users on each node for each
checkpoint. When a node restarts, the CPD update the total number of
users
for a checkpoint accordingly. This is reflected on
saCkptCheckpointNumOpeners attribute correctly.
Complete diffstat:
------------------
osaf/libs/common/cpsv/include/cpd_cb.h | 2 +
osaf/libs/common/cpsv/include/cpd_proc.h | 3 ++
osaf/libs/common/cpsv/include/cpd_red.h | 13 +++++++++++
osaf/libs/common/cpsv/include/cpsv_evt.h | 8 +++++++
osaf/services/saf/cpsv/cpd/cpd_db.c | 14 ++++++++++-
osaf/services/saf/cpsv/cpd/cpd_evt.c | 8 +++++++
osaf/services/saf/cpsv/cpd/cpd_mbcsv.c | 96
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------
osaf/services/saf/cpsv/cpd/cpd_proc.c | 148
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
osaf/services/saf/cpsv/cpd/cpd_red.c | 30 ++++++++++++++++++++------
osaf/services/saf/cpsv/cpd/cpd_sbevt.c | 57
+++++++++++++++++++++++++++++++++++++++++--------
10 files changed, 344 insertions(+), 35 deletions(-)
Testing Commands:
-----------------
Following old test steps
For in-service update:
Start SC-1 and PL-3 in old version
Start SC-2 and PL-4 in new version
Run ckpttest on each node
Testing, Expected Results:
--------------------------
All test cases passed
Conditions of Submission:
-------------------------
ACK from maintainer
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
