Summary:lga: ignore CLM status if client Initialize with A.2.1 [#1999] Review request for Trac Ticket(s): #1999 Peer Reviewer(s): Vu, Lennart,praveen Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): 5.1 default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests y Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset f97e26743a60d30eac24424404c43228c207e8e4 Author: A V Mahesh <[email protected]> Date: Wed, 07 Sep 2016 13:56:35 +0530 lga: ignore CLM status if client Initialize with A.2.1 [#1999] Issue : If client saLogInitialize with A.2.1 and linked with New agents lib A.2.2 code is considering CLM status. But as explained in osaf/services/saf/logsv/README old lga clients saLogInitialize with A.02.01 are always clm member, Fix: If client saLogInitialize() with A.2.1 , irrelevant of linked with New agents lib A.2.2 code or linked with Old agents lib A.2.1 code, CLM status will be ignored . Test code added two new test cases in testsuite 14 Please check test case 14 of /usr/bin/logtest -e 14 Complete diffstat: ------------------ osaf/libs/agents/saf/lga/lga.h | 1 + osaf/libs/agents/saf/lga/lga_api.c | 4 +++- osaf/libs/agents/saf/lga/lga_mds.c | 12 +++++++++--- tests/logsv/tet_Log_clm.c | 35 ++++++++++++++++++++++++++++++++++- 4 files changed, 47 insertions(+), 5 deletions(-) Testing Commands: ----------------- /usr/bin/logtest -e 14 Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc y y powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
