Dear Mahesh, The submitted patch correct the behavior of cpd_ckpt_db_entry_update() function to be similar to cpd_sb_proc_ckpt_create() in handling node_info. So both 2 cases have been considered.
Thank you and best regards, Hoang -----Original Message----- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Thursday, September 22, 2016 11:45 AM To: Hoang Vo <hoang.m...@dektech.com.au>; anders.wid...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1 of 1] cpd: coredump error while creating checkpoint after previous creating got error [#2055] Hi Hoang, Please check below cases as well ================================ uint32_t cpd_ckpt_db_entry_update(CPD_CB *cb, MDS_DEST *cpnd_dest, CPSV_ND2D_CKPT_CREATE *ckpt_create, CPD_CKPT_INFO_NODE **o_ckpt_node, CPD_CKPT_MAP_INFO **io_map_info) uint32_t cpd_sb_proc_ckpt_create(CPD_CB *cb, CPD_MBCSV_MSG *msg) ======================================================== -AVM On 9/21/2016 4:05 PM, Hoang Vo wrote: > osaf/services/saf/cpsv/cpd/cpd_proc.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > > Problem: > First creating time, cpd got error in creating immOm object and run to error handling steps, this free node_info memory without removing it from nsc_patricia_tree. > Second creating time, cpd try to access node_info and got error. > > Solution: > Do not free node_info memory here when this scope does not init it. Only free mode_info in cpd_cpnd_info_node_delete function. > > diff --git a/osaf/services/saf/cpsv/cpd/cpd_proc.c > b/osaf/services/saf/cpsv/cpd/cpd_proc.c > --- a/osaf/services/saf/cpsv/cpd/cpd_proc.c > +++ b/osaf/services/saf/cpsv/cpd/cpd_proc.c > @@ -383,11 +383,6 @@ uint32_t cpd_ckpt_db_entry_update(CPD_CB > } > } > > - if (node_info) { > - m_MMGR_FREE_CPD_CPND_INFO_NODE(node_info); > - > - } > - > TRACE_LEAVE(); > return proc_rc; > ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
