Hi Nagu, Praveen, I would like to push this patch, have you had any time to review?
/Thanks HansN From: Gary Lee [mailto:[email protected]] Sent: den 3 oktober 2016 23:03 To: Hans Nordebäck <[email protected]> Cc: Minh Chau H <[email protected]>; [email protected] Subject: Re: [devel] [PATCH 1 of 1] amfd: assert in avd_compcsi_cleanup_imm_object [#2081] Hi Hans Looks good. Ack. Thanks Gary On 4 Oct. 2016, at 12:08 am, Hans Nordebäck <[email protected]<mailto:[email protected]>> wrote: something like this: if (comp == nullptr) { LOG_WA("Component %s not found in comp_db", osaf_extended_name_borrow(&comp_name)); + osaf_extended_name_free(&comp_name); + continue; } /Thanks HansN On 10/03/2016 02:59 PM, Hans Nordebäck wrote: yes, you are right, the continue is missing, I'll add it. /Thanks HansN On 10/03/2016 10:22 AM, Gary Lee wrote: Hi Sorry, I missed the bit where comp is references later: susi = avd_susi_find(avd_cb, comp->su->name, si->name); I guess there should be a continue, after comp is null? Thanks On 3 Oct. 2016, at 7:18 pm, Gary Lee <[email protected]<mailto:[email protected]>> wrote: Hi Hans ack (review only) Thanks On 29 Sep. 2016, at 6:32 pm, Hans Nordeback <[email protected]<mailto:[email protected]>> wrote: osaf/services/saf/amf/amfd/csi.cc<http://csi.cc/> | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) Causes cyclic reboot of SC-1 during resilience testing diff --git a/osaf/services/saf/amf/amfd/csi.cc<http://csi.cc/> b/osaf/services/saf/amf/amfd/csi.cc<http://csi.cc/> --- a/osaf/services/saf/amf/amfd/csi.cc<http://csi.cc/> +++ b/osaf/services/saf/amf/amfd/csi.cc<http://csi.cc/> @@ -1585,8 +1585,10 @@ void avd_compcsi_cleanup_imm_object(AVD_ SaNameT comp_name; avsv_sanamet_init_from_association_dn(&dn, &comp_name, "safComp", csi->name.c_str()); AVD_COMP *comp = comp_db->find(Amf::to_string(&comp_name)); + if (comp == nullptr) { + LOG_WA("Component %s not found in comp_db", osaf_extended_name_borrow(&comp_name)); + } osaf_extended_name_free(&comp_name); - osafassert(comp); susi = avd_susi_find(avd_cb, comp->su->name, si->name); if (susi == nullptr || (susi->fsm == AVD_SU_SI_STATE_ABSENT)) { ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected]<mailto:[email protected]> https://lists.sourceforge.net/lists/listinfo/opensaf-devel ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org<http://slashdot.org/>! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected]<mailto:[email protected]> https://lists.sourceforge.net/lists/listinfo/opensaf-devel ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
