Dear Mahesh, ACK all three patches, tested, found no problem.
Sincerely, Hoang -----Original Message----- From: [email protected] [mailto:[email protected]] Sent: Tuesday, November 29, 2016 5:37 PM To: [email protected]; [email protected] Cc: [email protected] Subject: [PATCH 0 of 3] Review Request for leap : now leap library ensure shm availability before writing [#2202] Summary:leap : now leap library ensure shm availability before writing [#2202] Review request for Trac Ticket(s): #2202 Peer Reviewer(s): Hoang / Ramesh Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): <<LIST ALL AFFECTED BRANCH(ES)>> Development branch: <<IF ANY GIVE THE REPO URL>> -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries y Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 7b53e1b3754622fe90c22c801adeb7df6d808c30 Author: A V Mahesh <[email protected]> Date: Tue, 29 Nov 2016 15:59:21 +0530 leap : now leap library ensure shm availability before writing [#2202] Issue : If OSAF_CKPT_SHM_ALLOC_GUARANTEE is NOT set and SHM is 100% used in system , pnd Segmentation fault (core dumped) at LEAP memcpy(). Fix : Now LEAP library ensures shm free space before writing This may degrade some performance of cpsv , if OSAF_CKPT_SHM_ALLOC_GUARANTEE is set, cpsv give natural performance. changeset 083114e13c00c9c4267ffe65a86c1a97a951b876 Author: A V Mahesh <[email protected]> Date: Tue, 29 Nov 2016 16:02:06 +0530 cpsv : update cpsv error handing based on leap changes [#2202] changeset fb509abb1d1583315f585663fd75bf73e35211a6 Author: A V Mahesh <[email protected]> Date: Tue, 29 Nov 2016 16:02:58 +0530 mqsv : update mqsv error handing based on leap changes [#2202] Complete diffstat: ------------------ osaf/libs/common/cpsv/include/cpnd_cb.h | 4 ++-- osaf/libs/common/cpsv/include/cpnd_init.h | 8 ++++---- osaf/libs/common/cpsv/include/cpnd_sec.h | 2 +- osaf/libs/core/include/ncs_osprm.h | 2 +- osaf/libs/core/leap/os_defs.c | 20 ++++++++++++++++++-- osaf/services/saf/cpsv/cpnd/cpnd_db.c | 12 ++++++------ osaf/services/saf/cpsv/cpnd/cpnd_evt.c | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------- ------ osaf/services/saf/cpsv/cpnd/cpnd_proc.c | 31 ++++++++++++++++++------------- osaf/services/saf/cpsv/cpnd/cpnd_res.c | 24 ++++++++---------------- osaf/services/saf/cpsv/cpnd/cpnd_sec.cc | 12 ++++++------ osaf/services/saf/glsv/glnd/glnd_shm.c | 2 +- osaf/services/saf/mqsv/mqnd/mqnd_shm.c | 2 +- 12 files changed, 123 insertions(+), 78 deletions(-) Testing Commands: ----------------- Create situation that node SHM reaches 100% usage and then perform any CPSV operation which writes to SHM Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
