Hi Hung, Reviewed and tested the patch. Ack.
patch 3 of 3 is same as "[PATCH 0 of 1] Review Request for imm: Remove use of SaBoolT [#2225]" /Neel. On 2016/12/14 02:16 PM, Hung Nguyen wrote: > Summary: imm: Remove use of SaBoolT [#2225] > Review request for Trac Ticket(s): 2225 > Peer Reviewer(s): Zoran, Neel > Pull request to: > Affected branch(es): 5.2 > Development branch: 5.2 > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > > changeset 03a077ba8a5acf92d5d068f4db327722dd213af2 > Author: Hung Nguyen <hung.d.ngu...@dektech.com.au> > Date: Tue, 13 Dec 2016 09:40:26 +0700 > > imm: Remove use of SaBoolT from library [#2225] > > imm: Remove use of SaBoolT from library. > > changeset 3df2eb6a3a690f6336537baddd36285e34ef6240 > Author: Hung Nguyen <hung.d.ngu...@dektech.com.au> > Date: Tue, 13 Dec 2016 13:13:18 +0700 > > imm: Remove use of SaBoolT from IMMND [#2225] > > imm: Remove use of SaBoolT from IMMND. > > changeset 421945c108b10cfabda659cb5412fc1d482ee371 > Author: Hung Nguyen <hung.d.ngu...@dektech.com.au> > Date: Tue, 13 Dec 2016 13:40:11 +0700 > > imm: Remove use of SaBoolT from IMM tools and tests [#2225] > > imm: Remove use of SaBoolT from IMM tools and tests. > > > Complete diffstat: > ------------------ > osaf/libs/agents/saf/imma/imma_oi_api.cc | 6 +- > osaf/libs/agents/saf/imma/imma_om_api.cc | 48 > ++++++------ > osaf/services/saf/immsv/immnd/ImmModel.cc | 182 > ++++++++++++++++++++++++--------------------------- > osaf/services/saf/immsv/immnd/ImmModel.hh | 4 +- > osaf/services/saf/immsv/immnd/ImmSearchOp.cc | 6 +- > osaf/services/saf/immsv/immnd/ImmSearchOp.hh | 2 +- > osaf/services/saf/immsv/immnd/immnd_evt.c | 486 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------- > osaf/services/saf/immsv/immnd/immnd_init.h | 78 > ++++++++++---------- > osaf/services/saf/immsv/immnd/immnd_main.c | 4 +- > osaf/services/saf/immsv/immnd/immnd_proc.c | 74 > ++++++++++---------- > osaf/tools/safimm/immcfg/imm_cfg.c | 12 +- > osaf/tools/safimm/src/immutil.c | 4 +- > samples/immsv/immutils/immutil.c | 4 +- > tests/immsv/implementer/test_SaImmOiAdminOperation.c | 30 ++++---- > tests/immsv/implementer/test_SaImmOiRtAttrUpdateCallbackT.c | 4 +- > 15 files changed, 467 insertions(+), 477 deletions(-) > > > Testing Commands: > ----------------- > > > > Testing, Expected Results: > -------------------------- > > > > Conditions of Submission: > ------------------------- > Ack from reviewers. > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/intel _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel