Summary: amfd: return TRY_AGAIN on rollback of shutdown admin op [#2133]
Review request for Trac Ticket(s): #2133
Peer Reviewer(s): hans.nordeb...@ericsson.com, praveen.malv...@oracle.com,
minh.c...@dektech.com.au, gary....@dektech.com.au
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): Default
Development branch: Default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset af4a16ea73c02aa5cb92f003559a9282582dfa27
Author: Nagendra Kumar<nagendr...@oracle.com>
Date: Tue, 07 Feb 2017 11:36:23 +0530
amfd: return TRY_AGAIN on rollback of shutdown admin op [#2133] When
shutdown operation on SI is issued and if there are some faults
(component
failover, SU failover or node failover) on components on SU getting
quiescing csi cbk, then in the following situation TRY_AGAIN is
returned and
admin state is rolled back to unlock: For SI having only one SUSI:
Without SI Dep : a.) in comp fo. For SI having two SUSI: Without SI Dep
:
a.) in node fo, su fo, comp fo. With SI Dep : a.) node fo, su fo. In
other
cases below, the admin state is marked locked : For SI having only one
SUSI:
Without SI Dep : a.) node fo, su fo. With SI Dep : a.) node fo, su fo,
comp fo. For SI having two SUSI: With SI Dep : a.) Comp fo
Complete diffstat:
------------------
src/amf/amfd/sg_2n_fsm.cc | 17 +++++++++++++++++
src/amf/amfd/sgproc.cc | 13 ++++++++++---
2 files changed, 27 insertions(+), 3 deletions(-)
Testing Commands:
-----------------
A. Configure SI with only one SU Act on PL-3
------------------------------
Without SI Dep:
1. Configure comp failover and issue si shutdown, keep gdb in quiescing csi cbk
and kill component.
Operation is reverted and admin state is Unlocked and return type is TRY_AGAIN.
2. Configure SU failover and issue si shutdown, keep gdb in quiescing csi cbk
and kill component.
Operation succeeds and admin state of SI is locked and return type is OK.
3. Issue si shutdown, keep gdb in quiescing csi cbk and stop PL-3.
Operation succeeds and admin state of SI is locked and return type is OK.
With SI Dep: For all above steps, Operation succeeds and admin state of SI is
locked and return type is OK.
------------------------------
B. Configure SI with one SU Act on PL-3 and another SU standby on SC-1.
------------------------------
Without SI Dep: Operation is reverted and admin state is Unlocked and return
type is TRY_AGAIN.
With SI Dep: For steps #2 and #3, Operation is reverted and admin state is
Unlocked and return type is TRY_AGAIN.
For step #1, Operation succeeds and admin state of SI is locked
and return type is OK.
Testing, Expected Results:
--------------------------
As mentioned above.
Conditions of Submission:
-------------------------
Ack from maintainers.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
