Summary: lgs: Add new multivalue attributes to configuration handler
Review request for Trac Ticket(s): #2258
Peer Reviewer(s): vu.m.ngu...@dektech.com.au, mahesh.va...@oracle.com
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): <<LIST ALL AFFECTED BRANCH(ES)>>
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Fixed problem with deletingclearing all values and added test case for this
changeset 3a04c694bddf9ebc88faaae8ca296e600c7d7636
Author: Lennart Lund <lennart.l...@ericsson.com>
Date: Mon, 20 Feb 2017 16:08:50 +0100
lgs: Add new multivalue attributes to configuration handler [#2258]
Add new attributes to the configuration object and configuration info
object
The new attributes are multi value so multi value support is also added
NOTE: UML test fixed and new test cases added
Added Files:
------------
src/log/apitest/imm_tstutil.c
src/log/apitest/imm_tstutil.h
Complete diffstat:
------------------
src/log/Makefile.am | 5 +-
src/log/apitest/imm_tstutil.c | 126 +++++++++++++++++++++
src/log/apitest/imm_tstutil.h | 61 ++++++++++
src/log/apitest/logtest.h | 2 +-
src/log/apitest/saflogtest.c | 29 ----
src/log/apitest/tet_LogOiOps.c | 408
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/log/apitest/tet_Log_recov.c | 7 +-
src/log/apitest/tet_log_runtime_cfgobj.c | 9 +-
src/log/config/logsv_classes.xml | 27 ++++
src/log/logd/lgs.h | 2 +-
src/log/logd/lgs_config.cc | 507
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------
src/log/logd/lgs_config.h | 252
+++++++++++++++++++++++++++++++++++++++---
src/log/logd/lgs_evt.cc | 2 +-
src/log/logd/lgs_file.cc | 2 +-
src/log/logd/lgs_imm.cc | 69 ++++++++++-
src/log/logd/lgs_mbcsv.cc | 2 +-
src/log/logd/lgs_mbcsv_v5.cc | 2 +
17 files changed, 1344 insertions(+), 168 deletions(-)
Testing Commands:
-----------------
# logtest
Testing, Expected Results:
--------------------------
All tests shall pass. See especially test suite 5
Conditions of Submission:
-------------------------
Ack by reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
