Forgot to hg add the newly created file, will send the next version of the patch
Thanks, Neel. On 2017/02/21 11:08 AM, [email protected] wrote: > Summary: Integrate IMM service with CLM [#1640] > Review request for Trac Ticket(s): 1640 > Peer Reviewer(s): Zoran, Hung > Affected branch(es): default > Development branch: default > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset 88d7dc2e8243d138078cefc965ddd799e4fa2c4c > Author: Neelakanta Reddy <[email protected]> > Date: Tue, 21 Feb 2017 10:51:31 +0530 > > imm: README changes for integrating IMM with CLMS [#1640] > > changeset 5e544f27cfdbb3aca7d11e3d6b5ab94828a1e825 > Author: Neelakanta Reddy <[email protected]> > Date: Tue, 21 Feb 2017 10:53:46 +0530 > > imm: imm agent changes for integrating IMM with CLMS [#1640] > > changeset 2ba31b84493b426d744054df8ff82f92a9a49d11 > Author: Neelakanta Reddy <[email protected]> > Date: Tue, 21 Feb 2017 10:54:17 +0530 > > imm: immnd changes for integrating IMM with CLMS [#1640] > > > Complete diffstat: > ------------------ > src/imm/Makefile.am | 5 +++- > src/imm/README | 40 +++++++++++++++++++++++++++++++- > src/imm/agent/imma_cb.h | 11 ++++++-- > src/imm/agent/imma_db.cc | 37 ++++++++++++++++++++++++++++- > src/imm/agent/imma_init.cc | 2 + > src/imm/agent/imma_oi_api.cc | 96 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--- > src/imm/agent/imma_om_api.cc | 211 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------ > src/imm/agent/imma_proc.cc | 31 ++++++++++++++++++++++++ > src/imm/common/immsv_api.h | 3 +- > src/imm/common/immsv_evt.c | 15 +++++++++++ > src/imm/common/immsv_evt.h | 2 + > src/imm/immnd/ImmModel.cc | 44 ++++++++++++++++++++++++++++++---- > src/imm/immnd/ImmModel.h | 2 + > src/imm/immnd/immnd_cb.h | 18 ++++++++++++++ > src/imm/immnd/immnd_db.c | 125 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > src/imm/immnd/immnd_evt.c | 31 ++++++++++++++++++++--- > src/imm/immnd/immnd_init.h | 7 +++++ > src/imm/immnd/immnd_main.c | 42 +++++++++++++++++++++++++++++++-- > src/imm/immnd/immnd_mds.c | 30 +++++++++++++++++++++++- > src/nid/nodeinit.conf.payload | 2 +- > 20 files changed, 711 insertions(+), 43 deletions(-) > > > Testing Commands: > ----------------- > Test new IMM agent version A.02.18. > CLM membership status (when CLM is locked/unlocked) will be sent to agent, > only when agent is registered with A.02.18. > > old agent versions must work as it is. > > check the upgrade path from 5.1 to default(5.2) > > In case of CLM node lock, and HEADLESS is triggered after CLM node lock, then > CLM locked node > is nullified. The node is considered as HEADLESS and all other agent > functions supported in HEADLESS > are supported. > > Testing, Expected Results: > -------------------------- > when agent is connected with version A.02.18 CLM membership status will be > reflected at agent > when agent is connected with older versions, no CLM status will be sent to > agent. > > Conditions of Submission: > ------------------------- > Ack from Reviewers > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, SlashDot.org! http://sdm.link/slashdot > _______________________________________________ > Opensaf-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensaf-devel ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
