ACK.
While fixing cppcheck 1.77 I missed ` src/log/tests/` directory ,
sorry for that.
[/avm/staging-publish/src/log/tests/lgs_dest_test.cc:36]: (performance)
Function parameter 'attribute_name' should be passed by reference.
[/avm/staging-publish/src/log/tests/lgs_dest_test.cc:37]: (performance)
Function parameter 'value_list' should be passed by reference.
-AVM
On 3/8/2017 6:44 PM, Vu Minh Nguyen wrote:
> src/log/tests/lgs_dest_test.cc | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>
> Fix compiling the log unit test failed by correcting
> the dummy function to match with the prototype.
>
> diff --git a/src/log/tests/lgs_dest_test.cc b/src/log/tests/lgs_dest_test.cc
> --- a/src/log/tests/lgs_dest_test.cc
> +++ b/src/log/tests/lgs_dest_test.cc
> @@ -33,8 +33,8 @@ int lgs_cfg_update(const lgs_config_chg_
> return 0;
> }
>
> -void lgs_cfgupd_mutival_replace(const std::string attribute_name,
> - const std::vector<std::string> value_list,
> +void lgs_cfgupd_mutival_replace(const std::string& attribute_name,
> + const std::vector<std::string>& value_list,
> lgs_config_chg_t *config_data) {
> }
>
------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
