Hi Mahesh, yes, that is ok for me.
/Thanks HansN On 03/10/17 07:23, A V Mahesh wrote: > Hi Hans N, > > On 3/10/2017 11:49 AM, Hans Nordebäck wrote: >> Hi Mahesh, >> >> Yes, I think 'TIPC_RETDATA' can have INFO, and TIPC_ERR_OVERLOAD as >> is, i.e. ERROR. /Regards Hans > > can I change and directly push that Ok ? > > -AVM > >> >> -----Original Message----- >> From: A V Mahesh [mailto:mahesh.va...@oracle.com] >> Sent: den 10 mars 2017 04:52 >> To: Hans Nordebäck <hans.nordeb...@ericsson.com> >> Cc: opensaf-devel@lists.sourceforge.net >> Subject: Re: [devel] [PATCH 1 of 1] mds: reduce log level to Err for >> TIPC_ERR_OVERLOAD in syslog [#2350] >> >> Hi Hans N, >> >> >>I think we should lower it to IN >> >> what do you prefer to have for `TIPC_RETDATA` , do you mean INFO ? >> >> -AVM >> >> On 3/9/2017 8:20 PM, Hans Nordebäck wrote: >>> Hi Mahesh, >>> >>> I missed that this patch also changes TIPC_RETDATA from CR to ER, I >>> think we should lower it to IN as the failed send should be known at >>> the call to send. The TIPC_ERR_OVERLOAD is different, packages has >>> been dropped at receiver. There are test cases checking for ER in >>> the syslog that fails due to this change. >>> /Regards Hans >>> >>> -----Original Message----- >>> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] >>> Sent: den 7 mars 2017 07:57 >>> To: mahesh.va...@oracle.com >>> Cc: opensaf-devel@lists.sourceforge.net >>> Subject: Re: [devel] [PATCH 1 of 1] mds: reduce log level to Err for >>> TIPC_ERR_OVERLOAD in syslog [#2350] >>> >>> Ack, code review only/Thanks HansN >>> >>> -----Original Message----- >>> From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com] >>> Sent: den 7 mars 2017 03:39 >>> To: Hans Nordebäck <hans.nordeb...@ericsson.com> >>> Cc: opensaf-devel@lists.sourceforge.net >>> Subject: [PATCH 1 of 1] mds: reduce log level to Err for >>> TIPC_ERR_OVERLOAD in syslog [#2350] >>> >>> src/mds/mds_dt_tipc.c | 4 ++-- >>> 1 files changed, 2 insertions(+), 2 deletions(-) >>> >>> >>> Note : MDS still maintained as MDS_LOG_CRITICAL >>> >>> diff --git a/src/mds/mds_dt_tipc.c b/src/mds/mds_dt_tipc.c >>> --- a/src/mds/mds_dt_tipc.c >>> +++ b/src/mds/mds_dt_tipc.c >>> @@ -590,7 +590,7 @@ ssize_t recvfrom_connectionless (int sd, >>> if (anc->cmsg_type == TIPC_ERRINFO) { >>> anc_data[0] = *((unsigned >>> int*)(CMSG_DATA(anc) + 0)); >>> if (anc_data[0] == TIPC_ERR_OVERLOAD) { >>> - LOG_CR("MDTM: undelivered message condition >>> ancillary data: TIPC_ERR_OVERLOAD"); >>> + LOG_ER("MDTM: undelivered message condition >>> ancillary data: >>> +TIPC_ERR_OVERLOAD"); >>> m_MDS_LOG_CRITICAL("MDTM: undelivered >>> message condition ancillary data: TIPC_ERR_OVERLOAD"); >>> } else { >>> /* TIPC_ERRINFO - TIPC error code >>> associated with a returned data message or a connection termination >>> message */ @@ -600,7 +600,7 @@ ssize_t recvfrom_connectionless (int sd, >>> /* If we set TIPC_DEST_DROPPABLE off message >>> (configure TIPC to return rejected messages to the sender ) >>> we will hit this when we implement MDS >>> retransmit lost messages, can be replaced with flow control logic */ >>> /* TIPC_RETDATA -The contents of a returned >>> data message */ >>> - LOG_CR("MDTM: undelivered message condition >>> ancillary data: TIPC_RETDATA"); >>> + LOG_ER("MDTM: undelivered message condition >>> ancillary data: >>> +TIPC_RETDATA"); >>> m_MDS_LOG_CRITICAL("MDTM: undelivered message >>> condition ancillary data: TIPC_RETDATA"); >>> } else if (anc->cmsg_type == TIPC_DESTNAME) { >>> if (sz == 0) { >>> >>> ---------------------------------------------------------------------- >>> -------- Announcing the Oxford Dictionaries API! The API offers >>> world-renowned dictionary content that is easy and intuitive to >>> access. Sign up for an account today to start using our lexical data >>> to power your apps and projects. Get started today and enter our >>> developer competition. >>> http://sdm.link/oxford >>> _______________________________________________ >>> Opensaf-devel mailing list >>> Opensaf-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/opensaf-devel > ------------------------------------------------------------------------------ Announcing the Oxford Dictionaries API! The API offers world-renowned dictionary content that is easy and intuitive to access. Sign up for an account today to start using our lexical data to power your apps and projects. Get started today and enter our developer competition. http://sdm.link/oxford _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
