Summary: amfd: Check IMM service status before use IMM call [#2416]
Review request for Ticket(s): 2416
Peer Reviewer(s): AMF maintainers
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2416
Base revision: a7bb655d2e8b50bf22b168f7492eab9970a98849
Personal repository: git://git.code.sf.net/u/minh-chau/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision fb0a5e1d27a9eeac0aec4be18aaf4c1f648f6a6a
Author: Minh Chau <minh.c...@dektech.com.au>
Date: Wed, 17 May 2017 07:25:37 +1000
amfd: Check IMM service status before use IMM call [#2416]
When Opensaf 2N switchover, amfd tries to update some attributes
to IMM. But this time, IMM is not available since Opensaf 2N SI
is in QUIESCED.
SC-1 osafamfnd[510]: NO Assigned 'safSi=SC-2N,safApp=OpenSAF' QUIESCED to
'safSu=SC-1,safSg=2N,safApp=OpenSAF'
SC-1 osafamfd[496]: WA saImmOiRtObjectUpdate of
'safSISU=safSu=SC-1\,safSg=2N\,safApp=OpenSAF,safSi=SC-2N,safApp=OpenSAF'
osafAmfSISUFsmState failed with 5
SC-1 osafimmnd[441]: WA ERR_BAD_HANDLE: Handle use is blocked by pending reply
on syncronous call
This patch corrects the problem by checking IMM service status
before call avd_saImmOiRtXXX_sync. The problem does not appear
previously because IMM update is queued and FiFo::execute() does
check IMM status before executing a job. A check of @avail_state_avd
against SA_AMF_HA_ACTIVE is not enough in avd_saImmOiRtXXX_sync.
This patch does check IMM status in avd_saImmOiRtXXX_sync as similar
as FiFo::execute().
Complete diffstat:
------------------
src/amf/amfd/imm.cc | 35 ++++++++++++++++++++++++-----------
1 file changed, 24 insertions(+), 11 deletions(-)
Testing Commands:
-----------------
Swap Opensaf 2N SI
Testing, Expected Results:
--------------------------
No errors
Conditions of Submission:
-------------------------
Ack from reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
