Summary: amfnd: Refactor AVND_COMP for simpler environment variable handling [#1945] Review request for Ticket(s): 1945 Peer Reviewer(s): Nagu, Praveen, Gary Pull request to: Affected branch(es): develop Development branch: ticket-1945 Base revision: 184448da377a2212666d9e3f3254ce258402bb7e Personal repository: git://git.code.sf.net/u/hansnordeback/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 1cd2d021c59c2e21c1eebfdfb1e2b5b1e3722deb Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Thu, 18 May 2017 11:55:09 +0200 amfnd: Refactor AVND_COMP for simpler cmd argument handling V2 [#1945] revision 75df6b7ca99a5b78b3a9de044dc36d6a9ee8f712 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Thu, 18 May 2017 11:03:11 +0200 amfnd: Refactor AVND_SU to class and comp_list to std::vector [#1945] revision 71076d6a191c94bad43c16bd4f3b01f0c79ab031 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Thu, 18 May 2017 11:03:11 +0200 amfnd: Refactor AVND_COMP for simpler environment variable handling [#1945] Complete diffstat: ------------------ src/amf/amfnd/avnd_comp.h | 205 +++++++++++++++++++++++---------------------- src/amf/amfnd/avnd_err.h | 10 +-- src/amf/amfnd/avnd_hc.h | 2 +- src/amf/amfnd/avnd_proc.h | 10 +-- src/amf/amfnd/avnd_su.h | 119 ++++++++++++-------------- src/amf/amfnd/avnd_tmr.h | 16 ++-- src/amf/amfnd/avnd_util.h | 5 +- src/amf/amfnd/cam.cc | 2 +- src/amf/amfnd/chc.cc | 2 +- src/amf/amfnd/clc.cc | 166 +++++++----------------------------- src/amf/amfnd/comp.cc | 84 ++++++++++++++++++- src/amf/amfnd/compdb.cc | 181 +++++++++++----------------------------- src/amf/amfnd/err.cc | 29 ++----- src/amf/amfnd/proxydb.cc | 2 +- src/amf/amfnd/su.cc | 100 ++++++++++++---------- src/amf/amfnd/sudb.cc | 30 ++----- src/amf/amfnd/susm.cc | 208 +++++++++++++++------------------------------- src/amf/amfnd/tmr.cc | 6 +- src/amf/amfnd/util.cc | 10 +++ 19 files changed, 491 insertions(+), 696 deletions(-) Testing Commands: ----------------- *** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES *** Testing, Expected Results: -------------------------- *** PASTE COMMAND OUTPUTS / TEST RESULTS *** Conditions of Submission: ------------------------- *** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC *** Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel