Hi I will push a fix for this that: - OM handle is initialized once when imcn is started but is re-initialized in case of SA_ERR_UNAVAILABLE (which will never happen if properly initialized with version A, 2, 12) - imm-version will be handled so that OI and OM is always initialized with IMM version 'A', 2, 12
I will not include: - Not starting on standby. This will conflict with #2508. This can be fixed later via ticket #2234 Thanks Lennart > -----Original Message----- > From: Zoran Milinkovic > Sent: den 29 juni 2017 13:11 > To: praveen malviya <praveen.malv...@oracle.com>; Lennart Lund > <lennart.l...@ericsson.com>; Minh Hon Chau > <minh.c...@dektech.com.au> > Cc: opensaf-devel@lists.sourceforge.net > Subject: RE: [devel] [PATCH 0/5] Review Request for ntf: ntfimcn does not > handle SA_ERR_UNAVAILABLE [#2506] > > Hi Praveen, > > I checked saImmOmClassDescriptionGet_2() and the function returns > ERR_UNAVAILABLE only if IMM handle is initialized with A.2.18 and above > version. > > The problem here is that first OI handle is initialized with imm_version > variable, which version is A.2.12. Then OM handle is initialized with the same > variable. > So, here, after OI handle is initialized, imm_version is populated with the > latest IMM version, A.2.18. And then you initialize OM handle with A.2.18 > version. > > Thanks, > Zoran > > -----Original Message----- > From: praveen malviya [mailto:praveen.malv...@oracle.com] > Sent: den 29 juni 2017 06:52 > To: Lennart Lund <lennart.l...@ericsson.com>; Minh Hon Chau > <minh.c...@dektech.com.au> > Cc: opensaf-devel@lists.sourceforge.net > Subject: Re: [devel] [PATCH 0/5] Review Request for ntf: ntfimcn does not > handle SA_ERR_UNAVAILABLE [#2506] > > Hi Lennart, > > NTFIMCN initializes with IMM with SAF version A.02.12. > IMM integration with CLM is done in last release and for that SAF version is > A.02.18 (src/imm/README mentions it). > Like any legacy application, NTFIMCN should not get ERR_UNAVAILABLE from > IMM for any API call. > > Thanks, > Praveen > > > > On 28-Jun-17 8:48 PM, Lennart Lund wrote: > > Summary: ntf: ntfimcn does not handle SA_ERR_UNAVAILABLE [#2506] > > Review request for Ticket(s): 2506 Peer Reviewer(s): > > praveen.malv...@oracle.com; minh.c...@dektech.com.au Pull request > to: > > *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): > > develop Development branch: ticket-2506 Base revision: > > f089f030a322a43c79f3f259f07a4c42bb4d0da1 > > Personal repository: git://git.code.sf.net/u/elunlen/review > > > > -------------------------------- > > Impacted area Impact y/n > > -------------------------------- > > Docs n > > Build system n > > RPM/packaging n > > Configuration files n > > Startup scripts n > > SAF services y > > OpenSAF services n > > Core libraries n > > Samples n > > Tests n > > Other n > > > > > > Comments (indicate scope for each "y" above): > > --------------------------------------------- > > *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** > > > > revision beae5c3dacaa05fe68b50433251947d8c045cca7 > > Author: Lennart Lund <lennart.l...@ericsson.com> > > Date: Wed, 28 Jun 2017 17:09:23 +0200 > > > > ntf: ntfimcn does not handle SA_ERR_UNAVAILABLE [#2506] > > > > Changed according to comment from Minh. > > OM Handle is now initialized only when imcn process start and is > > reinitialized if SA_AIS_ERR_UNAVAILABLE Also comment about resource > > handling in case of error in get_rdn_attr_name() > > > > > > > > revision 7c3bc31dda6099becf7f246093d0bd7b0d652340 > > Author: Lennart Lund <lennart.l...@ericsson.com> > > Date: Wed, 28 Jun 2017 16:49:04 +0200 > > > > ntf: ntfimcn does not handle SA_ERR_UNAVAILABLE [#2506] > > > > Changed according to comment from Minh. > > OM Handle is now initialized only when imcn process start and is > > reinitialized if SA_AIS_ERR_UNAVAILABLE Also comment about resource > > handling in case of error in get_rdn_attr_name() > > > > long_description > > > > > > > > revision caa854ce873f90208a5a14894b51c997e25a924c > > Author: Lennart Lund <lennart.l...@ericsson.com> > > Date: Wed, 28 Jun 2017 16:49:04 +0200 > > > > ntf: ntfimcn does not handle SA_ERR_UNAVAILABLE [#2506] > > > > In ntfimcn the OM handle shall have a short lifespan. Change from > > creating a handle once when ntfimcn process starts to create a handle > > each time it is needed and finalize when no longer needed. > > > > > > > > revision 0db3b249ffa8d00b05cc7aefecb1d422c30c8faf > > Author: Lennart Lund <lennart.l...@ericsson.com> > > Date: Wed, 28 Jun 2017 16:49:04 +0200 > > > > ntf: ntfimcn does not handle SA_ERR_UNAVAILABLE [#2506] > > > > In ntfimcn the OM handle shall have a short lifespan. Change from > > creating a handle once when ntfimcn process starts to create a handle > > each time it is needed and finalize when no longer needed. > > > > Change start handling of ntfimcn (in ntf process) so the ntfimcn > > process is started on the active node only since the ntfimcn process > > is not doing anything on the standby node. Refactor/simplify code > accordingly. > > > > > > > > revision 71763df94b6d58d6e553fa26cc41dbd7cb7d264a > > Author: Lennart Lund <lennart.l...@ericsson.com> > > Date: Tue, 27 Jun 2017 16:05:44 +0200 > > > > ntf: ntfimcn does not handle SA_ERR_UNAVAILABLE [#2506] > > > > In ntfimcn the OM handle shall have a short lifespan. Change from > > creating a handle once when ntfimcn process starts to create a handle > > each time it is needed and finalize when no longer needed. > > > > > > > > revision 8f43f5d28b282812926d5a5bad29e604c76e4697 > > Author: Lennart Lund <lennart.l...@ericsson.com> > > Date: Mon, 26 Jun 2017 14:03:38 +0200 > > > > ntf: ntfimcn does not handle SA_ERR_UNAVAILABLE [#2506] > > > > In ntfimcn the OM handle shall have a short lifespan. Change from > > creating a handle once when ntfimcn process starts to create a handle > > each time it is needed and finalize when no longer needed. > > > > Change start handling of ntfimcn (in ntf process) so the ntfimcn > > process is started on the active node only since the ntfimcn process > > is not doing anything on the standby node. Refactor/simplify code > accordingly. > > > > > > > > Complete diffstat: > > ------------------ > > src/ntf/ntfimcnd/ntfimcn_imm.c | 205 > ++++++++++++++++++++++++++++------------ > > src/ntf/ntfimcnd/ntfimcn_imm.h | 11 ++- > > src/ntf/ntfimcnd/ntfimcn_main.h | 2 +- > > 3 files changed, 158 insertions(+), 60 deletions(-) > > > > > > Testing Commands: > > ----------------- > > *** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES *** > > > > > > Testing, Expected Results: > > -------------------------- > > *** PASTE COMMAND OUTPUTS / TEST RESULTS *** > > > > > > Conditions of Submission: > > ------------------------- > > *** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC *** > > > > > > Arch Built Started Linux distro > > ------------------------------------------- > > mips n n > > mips64 n n > > x86 n n > > x86_64 n n > > powerpc n n > > powerpc64 n n > > > > > > Reviewer Checklist: > > ------------------- > > [Submitters: make sure that your review doesn't trigger any > > checkmarks!] > > > > > > Your checkin has not passed review because (see checked entries): > > > > ___ Your RR template is generally incomplete; it has too many blank entries > > that need proper data filled in. > > > > ___ You have failed to nominate the proper persons for review and push. > > > > ___ Your patches do not have proper short+long header > > > > ___ You have grammar/spelling in your header that is unacceptable. > > > > ___ You have exceeded a sensible line length in your > headers/comments/text. > > > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > > > ___ You have incorrectly put/left internal data in your comments/files > > (i.e. internal bug tracking tool IDs, product names etc) > > > > ___ You have not given any evidence of testing beyond basic build tests. > > Demonstrate some level of runtime or other sanity testing. > > > > ___ You have ^M present in some of your files. These have to be removed. > > > > ___ You have needlessly changed whitespace or added whitespace crimes > > like trailing spaces, or spaces before tabs. > > > > ___ You have mixed real technical changes with whitespace and other > > cosmetic code cleanup changes. These have to be separate commits. > > > > ___ You need to refactor your submission into logical chunks; there is > > too much content into a single commit. > > > > ___ You have extraneous garbage in your review (merge commits etc) > > > > ___ You have giant attachments which should never have been sent; > > Instead you should place your content in a public tree to be pulled. > > > > ___ You have too many commits attached to an e-mail; resend as threaded > > commits, or place in a public tree for a pull. > > > > ___ You have resent this content multiple times without a clear indication > > of what has changed between each re-send. > > > > ___ You have failed to adequately and individually address all of the > > comments and change requests that were proposed in the initial review. > > > > ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, > > user.email etc) > > > > ___ Your computer have a badly configured date and time; confusing the > > the threaded patch review. > > > > ___ Your changes affect IPC mechanism, and you don't present any results > > for in-service upgradability test. > > > > ___ Your changes affect user manual and documentation, your patch series > > do not contain the patch that updates the Doxygen manual. > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most engaging > tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Opensaf-devel mailing list > Opensaf-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/opensaf-devel ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
