Summary: uml: Add support for IPv6 and update Linux version [#2593]
Review request for Ticket(s): 2593
Peer Reviewer(s): Hans
Pull request to: 
Affected branch(es): develop
Development branch: ticket-2593
Base revision: f3ef8eebf44f0eab4dcc65f83fe3119a77ef5067
Personal repository: git://git.code.sf.net/u/anders-w/review

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            n
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   y

NOTE: Patch(es) contain lines longer than 80 characers

Comments (indicate scope for each "y" above):
---------------------------------------------

revision 21be1b4dd277aa9280c9b9c560b9da80f879d700
Author: Anders Widell <anders.wid...@ericsson.com>
Date:   Mon, 25 Sep 2017 16:35:20 +0200

uml: Add support for IPv6 and update Linux version [#2593]

You can now select to use IPv6 addresses in UML, by using e.g. the following
command before starting the UML cluster:

  export IPADDRBASE=fe80::

Linux kernel has also been updated to version 4.13.3.



Complete diffstat:
------------------
 tools/cluster_sim_uml/README                       |   6 +
 tools/cluster_sim_uml/archive/scripts/10net.rc     |  17 ++-
 tools/cluster_sim_uml/archive/scripts/40opensaf.rc |   6 +-
 tools/cluster_sim_uml/build_uml                    |   6 +
 tools/cluster_sim_uml/opensaf                      |  45 +++++--
 tools/cluster_sim_uml/uml/build_uml                |  13 +-
 .../uml/config/{busybox-1.26.2 => busybox-1.27.2}  | 146 +++++++++++++--------
 .../{linux-4.10.1-i686 => linux-4.13.3-i686}       | 108 +++++++++++----
 .../{linux-4.10.1-x86_64 => linux-4.13.3-x86_64}   | 108 +++++++++++----
 9 files changed, 325 insertions(+), 130 deletions(-)


Testing Commands:
-----------------

Start UML using TIPC and TCP. Try "export IPADDRBASE=fe80::" before starting
UML: the nodes will in this case be configured with IPv6 addresses.

Testing, Expected Results:
--------------------------

OpenSAF shall start successfully in UML. Note that there are some minor issues
when starting OpenSAF using TCP with IPv6 addresses, but these are probably bugs
in DTM, and related to UML.


Conditions of Submission:
-------------------------

Ack from reviewer(s), or on 2017-10-02


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to