Summary: smfd: after cluster reboot, don't re-execute a campaign which has
already completed [#2648]
Review request for Ticket(s): 2648
Peer Reviewer(s): Rafael, Lennart, Vijay
Pull request to:
Affected branch(es): develop
Development branch: ticket-2648
Base revision: ee7cb901b8eb023502e3c21180afb78dd15c328b
Personal repository: git://git.code.sf.net/u/trguitar/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
V2
revision 7f596aaec865af7ca33074bbb498ffd5c8568191
Author: Alex Jones <alex.jo...@genband.com>
Date: Wed, 25 Oct 2017 12:58:54 -0400
smfd: after cluster reboot, don't re-execute a campaign which has already
completed [#2648]
smfd crashes after cluster reboot when campaign has completed but not
been committed
When the cluster is coming back up, and smfd gets active assignment,
it will immediately start executing the campaign. If the other SC is
not up yet, and PBE is enabled, then writes to IMM will fail with
NO_RESOURCES, and smfd will crash in updateImmAttr.
Don't re-execute a campaign that has already completed.
Complete diffstat:
------------------
src/smf/smfd/SmfCampaign.cc | 4 ++++
1 file changed, 4 insertions(+)
Testing Commands:
-----------------
1) enable PBE
2) run a campaign to ExecutionCompleted, but don't commit it
3) remove or rename the campaign file (to simulate drive not being mounted)
4) cluster reboot
5) only have 1 SC come up
6) smfd should crash when trying to call "setError" because it can't find the
campaign file
Testing, Expected Results:
--------------------------
smfd doesn't crash, and campaign doesn't get re-executed after cluster reboot
Conditions of Submission:
-------------------------
Ack from developer.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
