Summary: log: fix cpplint, cppcheck, replace NULL - Part2 [#2445] Review request for Ticket(s): 2445 Peer Reviewer(s): Lennart, Vu Pull request to: Vu Affected branch(es): develop Development branch: ticket-2445 Base revision: a46627453d9fcadc67f651bbb3d8560dccdc57c7 Personal repository: git://git.code.sf.net/u/canht32/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 10e839bc7c0a7a5cd9ba1f0a495e6c15dc86b8b7 Author: Canh Van Truong <[email protected]> Date: Mon, 30 Oct 2017 17:59:58 +0700 log: fix cpplint, cppcheck, replace NULL - Part2 [#2445] Fix cppcheck, cpplint, replace nullptr for following files: lgs_stream.*, lgs_recov.*, lgs_mds.*, lgs_imm.*, lgs_fmt.*, Added Files: ------------ src/log/logd/lgs_imm.h src/log/logd/lgs_mds.h Complete diffstat: ------------------ src/log/Makefile.am | 5 +- src/log/agent/lga_mds.cc | 2 +- src/log/logd/lgs.h | 97 +++------- src/log/logd/lgs_amf.cc | 3 + src/log/logd/lgs_amf.h | 2 + src/log/logd/lgs_cb.h | 112 ++++++----- src/log/logd/lgs_clm.cc | 6 +- src/log/logd/lgs_evt.cc | 2 + src/log/logd/lgs_fmt.cc | 164 ++++++++-------- src/log/logd/lgs_fmt.h | 1 + src/log/logd/lgs_imm.cc | 447 +++++++++++++++++++++---------------------- src/log/logd/lgs_imm.h | 46 +++++ src/log/logd/lgs_imm_gcfg.cc | 67 +++---- src/log/logd/lgs_main.cc | 31 +-- src/log/logd/lgs_mbcsv.cc | 271 +++++++++++++------------- src/log/logd/lgs_mbcsv_v1.cc | 100 +++++----- src/log/logd/lgs_mbcsv_v1.h | 2 +- src/log/logd/lgs_mbcsv_v2.cc | 143 +++++++------- src/log/logd/lgs_mbcsv_v2.h | 2 +- src/log/logd/lgs_mbcsv_v3.cc | 48 ++--- src/log/logd/lgs_mbcsv_v3.h | 5 +- src/log/logd/lgs_mbcsv_v5.cc | 66 +++---- src/log/logd/lgs_mbcsv_v5.h | 4 +- src/log/logd/lgs_mbcsv_v6.cc | 82 ++++---- src/log/logd/lgs_mbcsv_v6.h | 6 +- src/log/logd/lgs_mds.cc | 137 ++++++------- src/log/logd/lgs_mds.h | 30 +++ src/log/logd/lgs_recov.cc | 15 +- src/log/logd/lgs_recov.h | 1 + src/log/logd/lgs_stream.cc | 107 +++++------ src/log/logd/lgs_stream.h | 85 ++++---- 31 files changed, 1083 insertions(+), 1006 deletions(-) Testing Commands: ----------------- *** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES *** Testing, Expected Results: -------------------------- *** PASTE COMMAND OUTPUTS / TEST RESULTS *** Conditions of Submission: ------------------------- Ack from reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
