Summary: log: fix logtest 4 56 fail because egrep log file fail [#2662]
Review request for Ticket(s): 2662
Peer Reviewer(s): Lennart, Vu
Pull request to: Vu
Affected branch(es): develop
Development branch: ticket-2662
Base revision: 85f1d74d9c9bced41287d9e9021c13a862cd72b4
Personal repository: git://git.code.sf.net/u/canht32/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 3e6d9287e23a523f650a5be71aeb628aa8011963
Author: Canh Van Truong <canh.v.tru...@dektech.com.au>
Date: Tue, 31 Oct 2017 14:33:01 +0700
log: fix logtest 4 56 fail because egrep log file fail [#2662]
In test case logtest 4 56, it verifies that whether written log file format is
reflected correctly.
It finds and checks the log file that has been closed
(FILENAME_YYYYMMDD_HHMMSS_YYYYMMDD_HHMMSS.log).
But sometimes the log file has not been closed successfully due to timeout
reason, this cause
that test case can not find the log file to check the content.
The test case should also check with file format name:
FILENAME_YYYYMMDD_HHMMSS.log
Complete diffstat:
------------------
src/log/apitest/tet_LogOiOps.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
Testing Commands:
-----------------
Update test case logtest 4 56
Testing, Expected Results:
--------------------------
test case pass
Conditions of Submission:
-------------------------
Ack from reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
