Summary: base: Add support for recvfrom and sendto operations on UnixSocket [#2646] Review request for Ticket(s): 2646 Peer Reviewer(s): Ravi Pull request to: Affected branch(es): develop Development branch: ticket-2646 Base revision: fb42d73a1d0ec3aed4cd493269d99592c3e12985 Personal repository: git://git.code.sf.net/u/anders-w/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries y Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- revision ade43c9ee0867ab35dfc4e72023cb13e4b9720a8 Author: Anders Widell <[email protected]> Date: Tue, 28 Nov 2017 15:53:57 +0100 osaf: Flush OpenSAF internal log entries before rebooting [#2646] Flush log entries in the OpenSAF internal log server from memory to disk before rebooting the local node, to prevent loss of log messages. revision 5f19209a3a9ca2e3ac55ddbacc74cbefcc2f1fa4 Author: Anders Widell <[email protected]> Date: Tue, 28 Nov 2017 15:34:37 +0100 dtm: Add flush command for writing buffered log messages to disk [#2646] Add a new protocol message that can be recevied on the UNIX socket, that causes osaftransportd to write all buffered log messages from memory to disk. revision 91cc561608b6fd6ad0de26c4e27fb7b5d51481aa Author: Anders Widell <[email protected]> Date: Tue, 28 Nov 2017 15:34:27 +0100 base: Add support for recvfrom and sendto operations on UnixSocket [#2646] Add new UnixSocket methods for sending and receiving with a sockaddr_un address parameter. Also add support for abstract UNIX socket addresses and for providing a raw sockaddr_un address to UnixSocket. Added Files: ------------ src/dtm/common/osaflog_protocol.h src/dtm/tools/osaflog.cc Complete diffstat: ------------------ scripts/opensaf_reboot | 7 ++ src/base/logtrace.cc | 4 +- src/base/tests/unix_socket_test.cc | 35 ++++++++++ src/base/unix_client_socket.cc | 4 ++ src/base/unix_client_socket.h | 9 ++- src/base/unix_server_socket.cc | 32 ++++++--- src/base/unix_server_socket.h | 10 ++- src/base/unix_socket.cc | 23 ++++--- src/base/unix_socket.h | 105 +++++++++++++++++++++++++++- src/dtm/Makefile.am | 16 ++++- src/dtm/common/osaflog_protocol.h | 50 ++++++++++++++ src/dtm/dtmnd/dtmd.conf | 2 +- src/dtm/tools/osaflog.cc | 137 +++++++++++++++++++++++++++++++++++++ src/dtm/transport/log_server.cc | 76 ++++++++++++++------ src/dtm/transport/log_server.h | 9 +++ src/mds/mds_log.cc | 4 +- 16 files changed, 472 insertions(+), 51 deletions(-) Testing Commands: ----------------- Run the command "osaflog --flush" Testing, Expected Results: -------------------------- All MDS log and OpenSAF trace messages shall be flushed from memory to disk. Conditions of Submission: ------------------------- Ack from reviewer(s), or on 2017-12-05 if no comments have been received. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
