Summary: plm: handle plmc clients which abruptly terminated [#2529]
Review request for Ticket(s): 2529
Peer Reviewer(s): Mathi, Ravi
Pull request to:
Affected branch(es): develop
Development branch: ticket-2529
Base revision: 37983760835c40056c0a2d404e47f17f2a50b102
Personal repository: git://git.code.sf.net/u/trguitar/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
revision caa9f9f93e507748ec6fb43c97d83967f4c6045b
Author: Alex Jones <alex.jo...@genband.com>
Date: Thu, 7 Dec 2017 11:31:46 -0500
plm: handle plmc clients which abruptly terminated [#2529]
In virtual environments nodes can reboot very quickly (less than 1 minute). If
the reboot is abrupt, plmd may not be aware that the EE went down until after
it has already come back up because plmd relies on the TCP connection to plmcd
on the node. In this case, plmd will set the readiness state to OOS after the
EE is already back up. This causes CLM to evict the node from the cluster. plmd
should use TCP_USER_TIMEOUT to notice that plmcd has exited abruptly.
This enhancement also refactors the threading involved with handling the plm
clients, to support a large number of them.
Complete diffstat:
------------------
src/plm/plmcd/plmc.h | 3 +
src/plm/plmcd/plmc_lib.c | 94 +--
src/plm/plmcd/plmc_lib_internal.c | 1313 +++++++++++++++----------------------
src/plm/plmcd/plmc_lib_internal.h | 13 +-
src/plm/plmcd/plmc_read_config.c | 16 +
src/plm/plmcd/plmcd.conf | 8 +
src/plm/plmd/plms_plmc.c | 4 +
7 files changed, 618 insertions(+), 833 deletions(-)
Testing Commands:
-----------------
In a virtualized environment, abruptly reboot a payload node (e.g. using
reboot -f)
Testing, Expected Results:
--------------------------
The EE presence state should be UNINSTANTIATED within 5 seconds, and the node
should come back into the cluster
Conditions of Submission:
-------------------------
Dec 13 or ack from developer
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
