Summary: fmd: prevent data races between MDS and main threads V2 [#2763]
Review request for Ticket(s): 2763
Peer Reviewer(s): Anders
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2763
Base revision: e61e96acac6428f53545ad9b6f4203f3032a51c3
Personal repository: git://git.code.sf.net/u/userid-2226215/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Changes from V1:
* remove m_MMGR_ALLOC_FM_CB
* remove m_MMGR_FREE_FM_CB
* fm_cb is allocated with new
* gfm_rcv_msg->info.node_info.node_name is not always null-terminated,
so osaf_extended_name_borrow() cannot be used. Instead, construct
a std::string directly from it.
revision 6ef8c1bb1a2e491205a6a49cdacd9331cc7c15a4
Author: Gary Lee <gary....@dektech.com.au>
Date: Tue, 13 Feb 2018 14:53:24 +1100
fmd: prevent data races between MDS and main threads [#2763]
Complete diffstat:
------------------
src/fm/fmd/fm_cb.h | 89 ++++++++++++++++++++++++++-------------------------
src/fm/fmd/fm_main.cc | 38 +++++++++++-----------
src/fm/fmd/fm_mds.cc | 35 +++++++++++---------
src/fm/fmd/fm_mds.h | 2 ++
src/fm/fmd/fm_mem.h | 8 -----
5 files changed, 86 insertions(+), 86 deletions(-)
Testing Commands:
-----------------
Run regresion tests
Testing, Expected Results:
--------------------------
No error
Conditions of Submission:
-------------------------
Ack from reviewer
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
