Ack with comments, marked AndersW> below.

regards,

Anders Widell


On 03/27/2018 02:26 PM, syam-talluri wrote:
        modified:   00-README.conf
        modified:   src/dtm/README
---
  00-README.conf | 15 +++++++++++++++
  src/dtm/README | 23 +++++++++++++++++++++++
  2 files changed, 38 insertions(+)

diff --git a/00-README.conf b/00-README.conf
index 94cb3d3..5f3927b 100644
--- a/00-README.conf
+++ b/00-README.conf
@@ -102,6 +102,21 @@ DTM_MCAST_ADDR=file:/var/lib/peer_ip_addresses.txt
  DTM_MCAST_ADDR=dns:peers.opensaf.org
*******************************************************************************
+transportd.conf
+
+This file contains the configuration for transportd Service. This file
+has to be modified in the following cases:
+
+(a) To override the default max log file size (5242880 bytes) and
+    default number of log backups (9 log backups).

AndersW> Is case (a) really a separate case? I think you should remove it and just keep case (b) and (c) below. You can mention the default values in case (b) and (c).

+(b) To override the default max log file size, enable the option
+    TRANSPORT_MAX_LOG_FILESIZE by removing # in the starting of
+    the line and update its value to the required number of bytes.
+(c) To override the default number of log backups, enable the option
+    TRANSPORT_NO_OF_BACKUP_LOG_FILES by removing # in the starting of
+    the line and update its value to the required number of backups.

AndersW> I realize now that the names of these two configuration options are different from the command-line options of the osaflog tool. This can be confusing since they control the same settings. Rename TRANSPORT_MAX_LOG_FILESIZE to TRANSPORT_MAX_FILE_SIZE and TRANSPORT_NO_OF_BACKUP_LOG_FILES to TRANSPORT_MAX_BACKUPS. You will of course update the names in transportd.conf and log_server.cc too.

+
+*******************************************************************************
  nid.conf
This file contains global configuration for OpenSAF. This file
diff --git a/src/dtm/README b/src/dtm/README
index bccd8fe..814e49a 100644
--- a/src/dtm/README
+++ b/src/dtm/README
@@ -168,3 +168,26 @@ in dtmd.conf (see CONFIGURATION above) and restart the 
cluster.
For fatal errors, syslog is used. +Command Line Tool:
+
+Use the osaflog command line tool to change the log server configuration.
+osaflog tool supports the below options.
+
+Usage: osaflog [OPTION] [LOGSTREAM]
+
+print the messages stored on disk for the specified
+LOGSTREAM. When a LOGSTREAM argument is specified, the option
+--flush is implied.
+
+Opions:
+
+--flush          Flush all buffered messages in the log server to
+                 disk even when no LOGSTREAM is specified
+--print          print the messages stored on disk for the
+                 specified LOGSTREAM.This option is default
+                 when no option is specified.
+--max-file-size  Set the maximum size (in bytes) of the log file
+                 before the log is rotated.
+--max-backups    Set the maximum number of backup files to keep
+                 when rotating the log.

AndersW> To make it more visible that the last two options require arguments,
change the description of them to:

--max-file-size=SIZE  Set the maximum size of the log file to SIZE bytes.
                      The log file will be rotated when it exceeds this size.
--max-backups=NUM     Set the maximum number of backup files to retain during
                      log rotation to NUM.

Also make the same change in osaflog.cc

+


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to