Summary: osaf:Isolate the node in the opensaf_reboot[#2833] Review request for Ticket(s): 2833 Peer Reviewer(s): Anders, Hans Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2833 Base revision: aff54ff091727f27830443332b830890668749cf Personal repository: git://git.code.sf.net/u/ravi-sekhar/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 799e5b098e4932929a5710df36395eafbb155605 Author: ravi-sekhar <ravisekhar.ko...@oracle.com> Date: Thu, 12 Apr 2018 18:40:19 +0530 osaf: Isolate the node in the opensaf_reboot [#2833] Complete diffstat: ------------------ scripts/opensaf_reboot | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) Testing Commands: ----------------- Bring up the demo application on SC-1(Active) and SC-2(Standby) such that application on SC-2 is Active and on SC-1 is Standby Simulate the link flickering 1) TCP confifured systems for simulating link down use: tipc-config -bd eth:eth0 for simulating link down use: tipc-config -be eth:eth0 2) TIPC configured systems: for simulating link down use: ifconfig eth0 down for simulating link up use: ifconfig eth0 up Testing, Expected Results: -------------------------- The node should get isolated immediatly, so that we won't see two active SUs ata a time Conditions of Submission: ------------------------- Ack from reviewer on or before Aprili 20 Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel