Thanks Hans, I modified code a bit to test this change, and found that immnd was respawned successfully as we expected. Here are the syslogs:
May 10 10:20:09 PL-3 local0.notice osafimmnd[436]: NO SERVER STATE: IMM_SERVER_LOADING_PENDING --> IMM_SERVER_SYNC_PENDING May 10 10:20:09 PL-3 local0.notice osafimmnd[436]: NO NODE STATE-> IMM_NODE_ISOLATED May 10 10:20:10 PL-3 local0.notice osafimmnd[436]: NO NODE STATE-> IMM_NODE_W_AVAILABLE May 10 10:20:10 PL-3 local0.notice osafimmnd[436]: NO SERVER STATE: IMM_SERVER_SYNC_PENDING --> IMM_SERVER_SYNC_CLIENT May 10 10:20:10 PL-3 local0.err osafimmnd[436]: ER Sync MESSAGE:1470 OUT OF ORDER my highest processed:1469 - exiting May 10 10:20:10 PL-3 local0.err opensafd[400]: ER Failed DESC:IMMND May 10 10:20:10 PL-3 local0.err opensafd[400]: ER Going for recovery May 10 10:20:10 PL-3 local0.err opensafd[400]: ER Trying To RESPAWN /usr/local/lib/opensaf/clc-cli/osaf-immnd attempt #1 May 10 10:20:25 PL-3 local0.info osafimmnd[464]: mkfifo already exists: /var/lib/opensaf/osafimmnd.fifo File exists May 10 10:20:25 PL-3 local0.notice osafimmnd[464]: Started ... Regards, Vu > -----Original Message----- > From: Hans Nordebäck <hans.nordeb...@ericsson.com> > Sent: Wednesday, May 9, 2018 4:12 PM > To: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>; > ravisekhar.ko...@oracle.com; Anders Widell > <anders.wid...@ericsson.com>; Lennart Lund <lennart.l...@ericsson.com> > Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen > <vu.m.ngu...@dektech.com.au> > Subject: RE: [PATCH 1/1] imm: inform status to NID before exit during start- > up phrase [#2845] > > Hi Vu, > > I'll revise my comment a bit, before sending nid_notify, the fifo monitoring is > not started. So removing the exit should not be necessary, good if > you can test this. > > /Thanks HansN > > -----Original Message----- > From: Hans Nordebäck > Sent: den 8 maj 2018 15:06 > To: 'Vu Minh Nguyen' <vu.m.ngu...@dektech.com.au>; > ravisekhar.ko...@oracle.com; Anders Widell > <anders.wid...@ericsson.com>; Lennart Lund <lennart.l...@ericsson.com> > Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen > <vu.m.ngu...@dektech.com.au> > Subject: RE: [PATCH 1/1] imm: inform status to NID before exit during start- > up phrase [#2845] > > Hi Vu, > > Ack review only with one comment. If the exit() is called after > immnd_ackToNid() the fifo monitoring in nodeinit.cc will be activated. > I think you should remove the exit(). > /Thanks HansN > > -----Original Message----- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 3 maj 2018 12:20 > To: ravisekhar.ko...@oracle.com; Hans Nordebäck > <hans.nordeb...@ericsson.com>; Anders Widell > <anders.wid...@ericsson.com>; Lennart Lund <lennart.l...@ericsson.com> > Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen > <vu.m.ngu...@dektech.com.au> > Subject: [PATCH 1/1] imm: inform status to NID before exit during start-up > phrase [#2845] > > During node starts up phrase, which AMFD has not been come up, there is a > case IMMND exit without informing failure result to NID (refer to the ticket > to see syslog). As the result, IMMND may not be respawned by NID process. > > This patch ensures that NID is informed before exit. > --- > src/imm/immnd/immnd_evt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/imm/immnd/immnd_evt.c b/src/imm/immnd/immnd_evt.c > index 8f3af92..2b9123d 100644 > --- a/src/imm/immnd/immnd_evt.c > +++ b/src/imm/immnd/immnd_evt.c > @@ -10779,6 +10779,7 @@ static uint32_t > immnd_evt_proc_fevs_rcv(IMMND_CB *cb, IMMND_EVT *evt, > LOG_ER( > "MESSAGE:%llu OUT OF ORDER my highest > processed:%llu - exiting", > msgNo, cb->highestProcessed); > + immnd_ackToNid(NCSCC_RC_FAILURE); > exit(1); > } else if (cb > ->mSync) { /* If we receive out of sync message > -- > 1.9.1 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
