Hi Lennart, We have many classes which have empty value in <default-value> tags.
If you look at the src/imm/config/SAI-AIS-IMM-XSD-A.02.17.xsd, there is no restrictions on the length of string value for <default-value> tag. We should use minLength constraints such as `<xs:minLength value="1"/>` if we do not allow empty value for <default-value> tag. Since empty value is allowed for the tag, we should have code to handle the case, I think. Regards, Vu > -----Original Message----- > From: Lennart Lund <lennart.l...@ericsson.com> > Sent: Wednesday, August 1, 2018 7:39 PM > To: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>; Hans Nordebäck > <hans.nordeb...@ericsson.com>; Gary Lee <gary....@dektech.com.au> > Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen > <vu.m.ngu...@dektech.com.au>; Lennart Lund > <lennart.l...@ericsson.com> > Subject: RE: [PATCH 0/1] Review Request for imm: attrDefaultValue is set to > NULL if no default value is given [#2901] > > Hi Vu > > In what situation may a configuration xml file be created where a class > definition has a <default-value></default-value> tag with no default value? > Does not seems correct and should probably not be allowed (loading such file > should fail). I there some reason for allowing that? > > Thanks > Lennart > > > -----Original Message----- > > From: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> > > Sent: den 30 juli 2018 10:47 > > To: Hans Nordebäck <hans.nordeb...@ericsson.com>; Lennart Lund > > <lennart.l...@ericsson.com>; Gary Lee <gary....@dektech.com.au> > > Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen > > <vu.m.ngu...@dektech.com.au> > > Subject: [PATCH 0/1] Review Request for imm: attrDefaultValue is set to > > NULL if no default value is given [#2901] > > > > Summary: imm: attrDefaultValue is set to NULL if no default value is given > > [#2901] > > Review request for Ticket(s): 2901 > > Peer Reviewer(s): Hans, Lennart, Hans > > Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** > > Affected branch(es): develop > > Development branch: ticket-2901 > > Base revision: ede5191f9caf41836a65acaffd648e7ac0b00590 > > Personal repository: git://git.code.sf.net/u/winhvu/review > > > > -------------------------------- > > Impacted area Impact y/n > > -------------------------------- > > Docs n > > Build system n > > RPM/packaging n > > Configuration files n > > Startup scripts n > > SAF services n > > OpenSAF services n > > Core libraries n > > Samples n > > Tests n > > Other y > > > > > > Comments (indicate scope for each "y" above): > > --------------------------------------------- > > *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** > > > > revision 8988402ca895f084ec4dad4b683b740bb52830e7 > > Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> > > Date: Mon, 30 Jul 2018 13:16:38 +0700 > > > > imm: attrDefaultValue is set to NULL if no default value is given [#2901] > > > > When explicitly having <default-value> tag, but no value is given: > > <default-value></default-value>, set NULL to attrDefaultValue. > > > > > > > > Complete diffstat: > > ------------------ > > src/imm/immloadd/imm_loader.cc | 3 ++- > > src/imm/tools/imm_import.cc | 3 ++- > > 2 files changed, 4 insertions(+), 2 deletions(-) > > > > > > Testing Commands: > > ----------------- > > Load the attached file from the ticket, then create one object > > immcfg -c TestClass testClass=1 > > > > View or dump that object using immlist/immdump > > > > > > Testing, Expected Results: > > -------------------------- > > 1) StringAttribute has <Empty> value > > 2) StringAttribute attribute has not been dumped to the target file > > > > > > Conditions of Submission: > > ------------------------- > > Ack from reviewers > > > > > > Arch Built Started Linux distro > > ------------------------------------------- > > mips n n > > mips64 n n > > x86 n n > > x86_64 n n > > powerpc n n > > powerpc64 n n > > > > > > Reviewer Checklist: > > ------------------- > > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > > > > Your checkin has not passed review because (see checked entries): > > > > ___ Your RR template is generally incomplete; it has too many blank entries > > that need proper data filled in. > > > > ___ You have failed to nominate the proper persons for review and push. > > > > ___ Your patches do not have proper short+long header > > > > ___ You have grammar/spelling in your header that is unacceptable. > > > > ___ You have exceeded a sensible line length in your > > headers/comments/text. > > > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > > > ___ You have incorrectly put/left internal data in your comments/files > > (i.e. internal bug tracking tool IDs, product names etc) > > > > ___ You have not given any evidence of testing beyond basic build tests. > > Demonstrate some level of runtime or other sanity testing. > > > > ___ You have ^M present in some of your files. These have to be removed. > > > > ___ You have needlessly changed whitespace or added whitespace crimes > > like trailing spaces, or spaces before tabs. > > > > ___ You have mixed real technical changes with whitespace and other > > cosmetic code cleanup changes. These have to be separate commits. > > > > ___ You need to refactor your submission into logical chunks; there is > > too much content into a single commit. > > > > ___ You have extraneous garbage in your review (merge commits etc) > > > > ___ You have giant attachments which should never have been sent; > > Instead you should place your content in a public tree to be pulled. > > > > ___ You have too many commits attached to an e-mail; resend as threaded > > commits, or place in a public tree for a pull. > > > > ___ You have resent this content multiple times without a clear indication > > of what has changed between each re-send. > > > > ___ You have failed to adequately and individually address all of the > > comments and change requests that were proposed in the initial review. > > > > ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email > > etc) > > > > ___ Your computer have a badly configured date and time; confusing the > > the threaded patch review. > > > > ___ Your changes affect IPC mechanism, and you don't present any results > > for in-service upgradability test. > > > > ___ Your changes affect user manual and documentation, your patch series > > do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
