Summary: plmcd: replace inet_aton with inet_pton [#207] Review request for Ticket(s): 207 Peer Reviewer(s): Alex, Mathi Pull request to: Alex, Mathi Affected branch(es): develop Development branch: ticket-207 Base revision: 6fe692e1e6cf64d9de9976f9aab0342f021c59a7 Personal repository: git://git.code.sf.net/u/meenatk-hasoln/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 86f978cec1773b77d9022520b1f6b580603cdd8f Author: Meenakshi TK <[email protected]> Date: Thu, 27 Sep 2018 13:54:53 +0530 plmcd: replace inet_aton with inet_pton [#207] Complete diffstat: ------------------ src/plm/plmcd/plmc_lib_internal.c | 4 ++-- src/plm/plmcd/plmcd.c | 17 ++++++++++------- 2 files changed, 12 insertions(+), 9 deletions(-) Testing Commands: ----------------- 1. Started opensaf 2. Started plmcd Testing, Expected Results: -------------------------- 1. Initially when plmcd starts, the entity along with the controller to which it is connected is shown in the syslog. Sep 27 13:49:46 meena-VM plmcd[32272]: ee_id safEE=SC-1,safDomain=domain_1 : EE_ Sep 27 13:49:46 meena-VM plmcd[32272]: Attempting to connect to controller 1 Sep 27 13:49:46 meena-VM plmcd[32272]: Connected to controller 1 2. Issuing a lock operation on the entity safEE=SC-1,safDomain=domain_1 using the command "immadm -o 1 safEE=SC-1,safDomain=domain_1": Sep 27 13:50:20 meena-VM plmcd[32272]: RECV command: PLMC_SA_PLM_ADMIN_LOCK Sep 27 13:50:20 meena-VM plmcd[32272]: Running, system('/bin/systemctl stop >/de Sep 27 13:50:20 meena-VM osafamfd[32016]: NO Node Left is self: ignoring Sep 27 13:50:20 meena-VM osafamfnd[32032]: NO This node has exited the cluster 3.After the lock operation is completed, immlist is done on the entity using the command "immlist safEE=SC-1,safDomain=domain_1": Name Type Value(s) ======================================================================== safEE SA_STRING_T safEE=SC-1 saPlmEEType SA_NAME_T safVersion=1,safEEType=Linux_os (31) saPlmEETerminateTimeout SA_TIME_T 180000000000 (0x29e8d60800, Thu Jan 1 05:33:00 1970) saPlmEEReadinessState SA_UINT32_T 1 (0x1) saPlmEEReadinessFlags SA_UINT64_T 0 (0x0) saPlmEEPresenceState SA_UINT32_T 3 (0x3) saPlmEEOperationalState SA_UINT32_T 1 (0x1) saPlmEEInstantiateTimeout SA_TIME_T 180000000000 (0x29e8d60800, Thu Jan 1 05:33:00 1970) saPlmEEAdminState SA_UINT32_T 2 (0x2) SaImmAttrImplementerName SA_STRING_T safPlmService SaImmAttrClassName SA_STRING_T SaPlmEE SaImmAttrAdminOwnerName SA_STRING_T <Empty> 4.Subsequently, an unlock operation is performed on the entity using the command "immadm -o 2 safEE=SC-1,safDomain=domain_1": Sep 27 13:50:35 meena-VM plmcd[32272]: RECV command: PLMC_SA_PLM_ADMIN_UNLOCK Sep 27 13:50:35 meena-VM plmcd[32272]: Running, system('/bin/systemctl start >/d 5.After the unlock operation is completed, immlist is done on the entity using the command "immlist safEE=SC-1,safDomain=domain_1": Name Type Value(s) ======================================================================== safEE SA_STRING_T safEE=SC-1 saPlmEEType SA_NAME_T safVersion=1,safEEType=Linux_os (31) saPlmEETerminateTimeout SA_TIME_T 180000000000 (0x29e8d60800, Thu Jan 1 05:33:00 1970) saPlmEEReadinessState SA_UINT32_T 2 (0x2) saPlmEEReadinessFlags SA_UINT64_T 0 (0x0) saPlmEEPresenceState SA_UINT32_T 3 (0x3) saPlmEEOperationalState SA_UINT32_T 1 (0x1) saPlmEEInstantiateTimeout SA_TIME_T 180000000000 (0x29e8d60800, Thu Jan 1 05:33:00 1970) saPlmEEAdminState SA_UINT32_T 1 (0x1) SaImmAttrImplementerName SA_STRING_T safPlmService SaImmAttrClassName SA_STRING_T SaPlmEE SaImmAttrAdminOwnerName SA_STRING_T <Empty> Conditions of Submission: ------------------------- Ack from maintainer Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
