Hi Mohan,
I don't see the v2 patch in your review branch. Can you put it in
there? Only the v1 version is there.
Alex
On 10/10/2018 05:47 AM, Mohan Kanakam wrote:
__________________________________________________________________
NOTICE: This email was received from an EXTERNAL sender
__________________________________________________________________
Summary: ckpt: convert .c to .cc [#2932]
Review request for Ticket(s): 2932
Peer Reviewer(s): Hans Nordeback, Vu Minh Nguyen, Gary Lee, Alex Jones
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2932
Base revision: 07336929aae355f31a32f8c97ec26f095323cdfa
Personal repository: [1]git://git.code.sf.net/u/mohan-hasoln/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 0ceebb9a92fb025ce83a473547eb5a0a5cd68cf9
Author: Mohan Kanakam [2]<[email protected]>
Date: Wed, 10 Oct 2018 15:05:08 +0530
ckpt: incorporate compilation errors v2 [#2932]
revision 34ff1fa1717a0a53e65f5cdb4eeed8f303bbc45a
Author: Mohan Kanakam [3]<[email protected]>
Date: Mon, 8 Oct 2018 13:22:23 +0530
ckpt: convert .c to .cc [#2932]
Added Files:
------------
src/ckpt/ckptnd/cpnd_amf.cc
src/ckpt/ckptnd/cpnd_db.cc
src/ckpt/ckptnd/cpnd_evt.cc
src/ckpt/ckptnd/cpnd_init.cc
src/ckpt/ckptnd/cpnd_main.cc
src/ckpt/ckptnd/cpnd_mds.cc
src/ckpt/ckptnd/cpnd_proc.cc
src/ckpt/ckptnd/cpnd_res.cc
src/ckpt/ckptnd/cpnd_tmr.cc
Removed Files:
--------------
src/ckpt/ckptnd/cpnd_amf.c
src/ckpt/ckptnd/cpnd_db.c
src/ckpt/ckptnd/cpnd_evt.c
src/ckpt/ckptnd/cpnd_init.c
src/ckpt/ckptnd/cpnd_main.c
src/ckpt/ckptnd/cpnd_mds.c
src/ckpt/ckptnd/cpnd_proc.c
src/ckpt/ckptnd/cpnd_res.c
src/ckpt/ckptnd/cpnd_tmr.c
Complete diffstat:
------------------
src/ckpt/Makefile.am | 18 +-
src/ckpt/ckptnd/cpnd_amf.c | 356 ---
src/ckpt/ckptnd/cpnd_amf.cc | 356 +++
src/ckpt/ckptnd/cpnd_db.c | 983 -------
src/ckpt/ckptnd/cpnd_db.cc | 983 +++++++
src/ckpt/ckptnd/cpnd_evt.c | 5872
-----------------------------------------
src/ckpt/ckptnd/cpnd_evt.cc | 5873
++++++++++++++++++++++++++++++++++++++++++
src/ckpt/ckptnd/cpnd_init.c | 803 ------
src/ckpt/ckptnd/cpnd_init.cc | 804 ++++++
src/ckpt/ckptnd/cpnd_main.c | 102 -
src/ckpt/ckptnd/cpnd_main.cc | 102 +
src/ckpt/ckptnd/cpnd_mds.c | 1411 ----------
src/ckpt/ckptnd/cpnd_mds.cc | 1419 ++++++++++
src/ckpt/ckptnd/cpnd_proc.c | 3107 ----------------------
src/ckpt/ckptnd/cpnd_proc.cc | 3107 ++++++++++++++++++++++
src/ckpt/ckptnd/cpnd_res.c | 2024 ---------------
src/ckpt/ckptnd/cpnd_res.cc | 2024 +++++++++++++++
src/ckpt/ckptnd/cpnd_tmr.c | 169 --
src/ckpt/ckptnd/cpnd_tmr.cc | 169 ++
src/ckpt/common/cpsv_evt.c | 5 +-
src/ckpt/common/cpsv_evt.h | 31 +-
21 files changed, 14874 insertions(+), 14844 deletions(-)
Testing Commands:
-----------------
*** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES ***
Testing, Expected Results:
--------------------------
*** PASTE COMMAND OUTPUTS / TEST RESULTS ***
Conditions of Submission:
-------------------------
Hans Nordeback, Vu Minh Nguyen, Gary Lee, Alex Jones
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any
checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank
entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your
headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build
tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be
removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear
indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name,
user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any
results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch
series
do not contain the patch that updates the Doxygen manual.
References
1. https://protect-us.mimecast.com/s/2OfICBBnWBiG1z5H6KCFT
2. mailto:[email protected]
3. mailto:[email protected]
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
