Summary: imm: add an admin operation to regenerate db from memory [#2940] Review request for Ticket(s): 2940 Peer Reviewer(s): Lennart, Hans, Gary Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2940 Base revision: 3b80698770d599bc15b97119cbfd4098943d7643 Personal repository: git://git.code.sf.net/u/winhvu/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision ce82e10d19ce213ccf6c612c842da7e2d72e6ae7 Author: Vu Minh Nguyen <[email protected]> Date: Fri, 19 Oct 2018 09:55:25 +0700 imm: add an admin operation to regenerate db from memory [#2940] After split-brain recovery, there is possibility of having inconsistencies between IMM data model in memory held by IMMND and one in the back-end database (sqlite). That could happen as we might have 02 active IMMDs, 02 IMMND coordinators and more than one PBE processes accessing a shared pbe database. Change to such database from one therefore might not get noticed by the other. By using this admin operation ID and targeting to IMM, IMM will regenerate the back-end database from one in memory to keep them both consistent. immadm -o 303 safRdn=immManagement,safApp=safImmService Complete diffstat: ------------------ src/imm/README | 18 ++++++++++++++++++ src/imm/common/immsv_api.h | 4 +++- src/imm/immnd/ImmModel.cc | 22 +++++++++++++++++++++- src/imm/immnd/ImmModel.h | 3 ++- src/imm/immnd/immnd_init.h | 2 ++ src/imm/immnd/immnd_proc.c | 8 ++++++-- 6 files changed, 52 insertions(+), 5 deletions(-) Testing Commands: ----------------- Run cluster with pbe enable. Trigger command: immadm -o 303 safRdn=immManagement,safApp=safImmService Testing, Expected Results: -------------------------- ps -ef and see that PBE is restarted and run without the option "--recover": osafimmpbed --pbe /etc/opensaf/imm.db Conditions of Submission: ------------------------- Acks from peer reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
