Summary: plm: add missing test cases in saPlmFinalize() and saPlmDispatch() api's of plm apitest [#2938] Review request for Ticket(s): 2938-1 Peer Reviewer(s):Alex, Mathi Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2938-1 Base revision: f8a6848a1cdbff0b518c3db951e4689e260226c7 Personal repository: git://git.code.sf.net/u/meenatk-hasoln/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests y Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision fcc87d5fc5694b5a7369960d59f433fdec4043bf Author: Meenakshi TK <[email protected]> Date: Mon, 5 Nov 2018 17:59:02 +0530 plm: add missing test cases in saPlmReadinessTrack() api of plm apitest [#2938] revision 913cf89533d1a44ed3afa2d54a8c92b466368463 Author: Meenakshi TK <[email protected]> Date: Mon, 5 Nov 2018 17:58:02 +0530 plm: add missing test cases in saPlmEntityGroupAdd() api of plm apitest [#2938] revision 79c29b4fcd1fda676b76a08d8d6a18ef0f1a0a47 Author: Meenakshi TK <[email protected]> Date: Mon, 5 Nov 2018 17:56:09 +0530 plm: add missing test cases in saPlmEntityGroupRemove() api of plm apitest [#2938] revision 6b91a2485e087f454de603f7e5951f50bcc72f08 Author: Meenakshi TK <[email protected]> Date: Mon, 5 Nov 2018 17:54:00 +0530 plm: add missing test cases in saPlmEntityGroupDelete() api of plm apitest [#2938] revision f8621d2ad29d0855ab492f15b19422680bacda38 Author: Meenakshi TK <[email protected]> Date: Mon, 5 Nov 2018 17:50:51 +0530 plm: add missing test cases in saPlmEntityGroupCreate() api of plm apitest [#2938] revision 79f6361030f55703c525883d4f8e16d7b7905979 Author: Meenakshi TK <[email protected]> Date: Mon, 5 Nov 2018 17:48:03 +0530 plm: add missing test cases in saPlmFinalize() and saPlmDispatch() api's of plm apitest [#2938] Complete diffstat: ------------------ src/plm/apitest/test_saPlmDispatch.c | 77 +++++++++++++++++++ src/plm/apitest/test_saPlmEntityGroupAdd.c | 42 +++++++++++ src/plm/apitest/test_saPlmEntityGroupCreate.c | 51 +++++++++++++ src/plm/apitest/test_saPlmEntityGroupDelete.c | 20 +++++ src/plm/apitest/test_saPlmEntityGroupRemove.c | 103 ++++++++++++++++++++++++++ src/plm/apitest/test_saPlmFinalize.c | 10 +++ src/plm/apitest/test_saPlmInitialize.c | 24 ++++++ src/plm/apitest/test_saPlmReadinessTrack.c | 72 ++++++++++++++++++ 8 files changed, 399 insertions(+) Testing Commands: ----------------- ./plmtest Testing, Expected Results: -------------------------- Received value:'9' Expected value:'9' 20 PASSED SA_AIS_ERR_BAD_HANDLE - Invalid plm handle Received value:'9' Expected value:'9' 21 PASSED SA_AIS_ERR_BAD_HANDLE - Invalid plm handle Received value:'9' Expected value:'9' 22 PASSED SA_AIS_ERR_BAD_HANDLE - NULL pointer to plm handle Received value:'9' Expected value:'9' 23 PASSED SA_AIS_ERR_BAD_HANDLE - NULL pointer to plm handle Received value:'9' Expected value:'9' 24 PASSED SA_AIS_ERR_INVALID_PARAM - NULL pointer to plm handle Received value:'9' Expected value:'9' 25 PASSED SA_AIS_ERR_BAD_HANDLE - NULL pointer to plm handle and invalid selection object Received value:'9' Expected value:'9' 29 PASSED SA_AIS_ERR_BAD_HANDLE - NULL pointer to handle PLMSV:PLMA:ON Received value:'9' Expected value:'9' 5 PASSED saPlmEntityGroupCreate with plmhandle as null pointer - SA_AIS_ERR_BAD_HANDLE PLMSV:PLMA:ON Received value:'9' Expected value:'9' 21 PASSED saPlmEntityGroupAdd_17 - Add HE by passing null pointer to group handle SA_AIS_ERR_BAD_HANDLE PLMSV:PLMA:ON Received value:'7' Expected value:'7' 22 PASSED saPlmEntityGroupAdd_18 - Add HE by passing invalid pointer to entity names SA_AIS_ERR_BAD_HANDLE PLMSV:PLMA:ON Received value:'7' Expected value:'7' 23 PASSED saPlmEntityGroupAdd_19 - Add HE by passing invalid entityNamesNumber SA_AIS_ERR_INVALID_PARAM PLMSV:PLMA:ON Received value:'9' Expected value:'9' 41 PASSED saPlmEntityGroupRemove_19 to pass a invalid group handle SA_AIS_ERR_BAD_HANDLE PLMSV:PLMA:ON Received value:'7' Expected value:'7' 42 PASSED saPlmEntityGroupRemove_20 to pass invalid pointer to entity names SA_AIS_ERR_INVALID_PARAM PLMSV:PLMA:ON Received value:'7' Expected value:'7' 43 PASSED saPlmEntityGroupRemove_21 to pass invalid pointer to entity names and invalid entityNamesNumber SA_AIS_ERR_INVALID_PARAM PLMSV:PLMA:ON Received value:'7' Expected value:'7' 44 PASSED saPlmEntityGroupRemove_22 to pass invalid group handle and invalid pointer to entity names SA_AIS_ERR_INVALID_PARAM PLMSV:PLMA:ON Received value:'9' Expected value:'9' 45 PASSED saPlmEntityGroupRemove_23 to pass invalid group handle and entityNamesNumber SA_AIS_ERR_BAD_HANDLE PLMSV:PLMA:ON Received value:'9' Expected value:'9' 49 PASSED saPlmEntityGroupDelete_04 with null pointer to grouphandle - SA_AIS_ERR_BAD_HANDLE PLMSV:PLMA:ON Received value:'7' Expected value:'7' 44 PASSED saPlmReadinessNotificationFree with invalid param - SA_AIS_ERR_INVALID_PARAM PLMSV:PLMA:ON Received value:'9' Expected value:'9' 45 PASSED saPlmReadinessNotificationFree with bad handle - SA_AIS_ERR_BAD_HANDLE Conditions of Submission: ------------------------- Ack from maintainers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
