Hi Lennart , Vu, Polite remainder for review. Thanks Mohan High Availability Solutions Pvt. Ltd. www.hasolutions.in
--------- Original Message --------- Subject: [PATCH 0/7] Review Request for log: add new test cases in log apitest [#2915] From: "Mohan Kanakam" <mo...@hasolutions.in> Date: 11/9/18 12:27 pm To: lennart.l...@ericsson.com, vu.m.ngu...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net, "Mohan Kanakam" <mo...@hasolutions.in> Summary: log: add new test case of API saLogInitialize() of apitest [#2915] Review request for Ticket(s): 2915 Peer Reviewer(s):lennart, vu Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2915 Base revision: f8a6848a1cdbff0b518c3db951e4689e260226c7 Personal repository: git://git.code.sf.net/u/mohan-hasoln/review -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests y Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision d8becca4a681cc41a1a61d89bbfbf5ede8671e3e Author: Mohan Kanakam <mo...@hasolutions.in> Date: Fri, 9 Nov 2018 11:39:20 +0530 log: add new test case of API saLogStreamClose() of apitest [#2915] revision e672d0302d0c97811186cb83e7b3853d524a7cb8 Author: Mohan Kanakam <mo...@hasolutions.in> Date: Fri, 9 Nov 2018 11:38:35 +0530 log: add new test case of API saLogWriteLogAsync() of apitest [#2915] revision e3f60f011777afcd374dcf3fa5078ebf3a829689 Author: Mohan Kanakam <mo...@hasolutions.in> Date: Fri, 9 Nov 2018 11:37:27 +0530 log: add new test case of API saLogStreamOpen_2() of apitest [#2915] revision 4406ad75640e770a5fbbaa55d7efaf86e076e06d Author: Mohan Kanakam <mo...@hasolutions.in> Date: Fri, 9 Nov 2018 11:36:35 +0530 log: add new test case of API saLogFinalize() of apitest [#2915] revision ca293ae4206613d4f910f6bf39c438e8538e54b8 Author: Mohan Kanakam <mo...@hasolutions.in> Date: Fri, 9 Nov 2018 11:35:23 +0530 log: add new test case of API saLogDispatch() of apitest [#2915] revision ead9fd46ba405c42bc9547fa3b478a666eeea622 Author: Mohan Kanakam <mo...@hasolutions.in> Date: Fri, 9 Nov 2018 11:33:29 +0530 log: add new test case of API saLogSelectionObjectGet() of apitest [#2915] revision 6a694dafb78ce401cc0bcd357fad92b54d64d962 Author: Mohan Kanakam <mo...@hasolutions.in> Date: Fri, 9 Nov 2018 11:32:25 +0530 log: add new test case of API saLogInitialize() of apitest [#2915] Complete diffstat: ------------------ src/log/apitest/tet_saLogDispatch.c | 17 ++++++++++ src/log/apitest/tet_saLogFinalize.c | 9 +++++ src/log/apitest/tet_saLogInitialize.c | 49 +++++++++++++++++++++++++++ src/log/apitest/tet_saLogSelectionObjectGet.c | 9 +++++ src/log/apitest/tet_saLogStreamClose.c | 20 +++++++++++ src/log/apitest/tet_saLogStreamOpen_2.c | 15 ++++++++ src/log/apitest/tet_saLogWriteLogAsync.c | 25 ++++++++++++++ 7 files changed, 144 insertions(+) Testing Commands: ----------------- ./logtest Testing, Expected Results: -------------------------- 12 PASSED saLogInitialize() valid handle, valid callbacks and version as NULL 13 PASSED saLogInitialize() with handle as null, version as null 14 PASSED saLogInitialize() with handle as null and callbk as null 15 PASSED saLogInitialize() with all null values 18 PASSED saLogSelectionObjectGet() with finalized log handle 20 PASSED saLogDispatch() with finalized handle SA_AIS_ERR_BAD_HANDLE 21 PASSED saLogDispatch() with invalid handle SA_AIS_ERR_BAD_HANDLE 24 PASSED saLogFinalize() with finalized log handle 22 PASSED saLogStreamOpen with invalid handle 41 PASSED saLogWriteLogAsync() after LogFianlize 45 PASSED saLogStreamClose BAD_HANDLE Conditions of Submission: ------------------------- Ack from maintainers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
