Summary: amfd: do not assert when events are received in End state [#2963] Review request for Ticket(s): 2963 Peer Reviewer(s): Minh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2963 Base revision: f6997b2f50b61b9eb7e298e18b72b458fda3c3c8 Personal repository: git://git.code.sf.net/u/userid-2226215/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- revision 2cec33e87290d99797cc3aa71314388825aa0c7f Author: Gary Lee <[email protected]> Date: Fri, 16 Nov 2018 05:00:58 +0000 amfd: do not assert when events are received in End state [#2963] On the standby, receiving events in 'End' state is not entirely unexpected, depending on when the checkpoint arrives from the active. We should just log a message instead of asserting. 2018-11-16 00:49:22.096 SC-2 osafamfd[252]: NO Node 'PL-3' not found in failover_list. Create new entry 2018-11-16 00:49:22.097 SC-2 osafamfd[252]: NO New state '7' 2018-11-16 00:49:22.105 SC-2 osafdtmd[154]: ER recv() from node 0x2030f failed, errno=110 2018-11-16 00:49:22.106 SC-2 osafdtmd[154]: NO Lost contact with 'PL-3' 2018-11-16 00:49:22.106 SC-2 osafimmd[196]: NO MDS event from svc_id 25 (change:4, dest:566312912814258) 2018-11-16 00:49:22.106 SC-2 osafamfd[252]: src/amf/amfd/node_state.cc:338: MdsDown: Assertion 'false' failed. 2018-11-16 00:49:22.113 SC-2 osafamfnd[262]: ER AMFD has unexpectedly crashed. Rebooting node 2018-11-16 00:49:22.129 SC-2 osafamfnd[262]: Rebooting OpenSAF NodeId = 131599 EE Name = , Reason: AMFD has unexpectedly crashed. Rebooting node, OwnNodeId = 131599, SupervisionTime = 60 Complete diffstat: ------------------ src/amf/amfd/node_state.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) Testing Commands: ----------------- *** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES *** Testing, Expected Results: -------------------------- *** PASTE COMMAND OUTPUTS / TEST RESULTS *** Conditions of Submission: ------------------------- *** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC *** Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
