Hi Hans/Vu/Gary/Alex, Polite remainder for review. Thanks Mohan High Availability Solutions Pvt. Ltd. www.hasolutions.in
--------- Original Message --------- Subject: RE: [PATCH 0/3] Review Request for ckpt: add new test cases in apitest [#2939] From: mo...@hasolutions.in Date: 11/15/18 5:43 pm To: hans.nordeb...@ericsson.com, vu.m.ngu...@dektech.com.au, gary....@dektech.com.au, ajo...@rbbn.com Cc: opensaf-devel@lists.sourceforge.net, "Mohan Kanakam" <mo...@hasolutions.in> Hi Hans/Vu/Gary/Alex, Polite remainder for review. Thanks Mohan High Availability Solutions Pvt. Ltd. www.hasolutions.in --------- Original Message --------- Subject: [PATCH 0/3] Review Request for ckpt: add new test cases in apitest [#2939] From: "Mohan Kanakam" <mo...@hasolutions.in> Date: 10/12/18 7:00 pm To: hans.nordeb...@ericsson.com, vu.m.ngu...@dektech.com.au, gary....@dektech.com.au, ajo...@rbbn.com Cc: opensaf-devel@lists.sourceforge.net, "Mohan Kanakam" <mo...@hasolutions.in> Summary: ckpt: add new test case of API saCkptSectionCreate() of apitest [#2939] Review request for Ticket(s): 2939_3 Peer Reviewer(s):Hans Nordeback, Vu Minh Nguyen, Gary Lee, Alex Jones Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2939_3 Base revision: cad806745a2eb96024ff18081ccf6d208b0fb93b Personal repository: git://git.code.sf.net/u/mohan-hasoln/review -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests y Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision c661dce0f91d67ae65c4b880a8aab8f0845e3720 Author: Mohan Kanakam <mo...@hasolutions.in> Date: Fri, 12 Oct 2018 17:50:55 +0530 ckpt: add new test case of API saCkptSectionExpirationTimeSet() of apitest [#2939] revision d0057fc006121e480f8aea68ee242d261cd0bab4 Author: Mohan Kanakam <mo...@hasolutions.in> Date: Fri, 12 Oct 2018 17:26:51 +0530 ckpt: add new test case of API saCkptSectionDelete() of apitest [#2939] revision bec0bacba2a5f2d3f9489ab63707a73632db304c Author: Mohan Kanakam <mo...@hasolutions.in> Date: Fri, 12 Oct 2018 16:24:44 +0530 ckpt: add new test case of API saCkptSectionCreate() of apitest [#2939] Complete diffstat: ------------------ src/ckpt/apitest/test_cpa.c | 232 +++++++++++++++++++++++++++++++++++++++ src/ckpt/apitest/test_cpa_util.c | 13 +++ src/ckpt/apitest/test_cpsv.h | 3 + 3 files changed, 248 insertions(+) Testing Commands: ----------------- ./ckpttest Testing, Expected Results: -------------------------- 6 PASSED To verify section exp set after finalize 7 PASSED To verify section exp set after close 7 PASSED To verify section delete after finalize 8 PASSED To verify section delete after close 17 PASSED To verify Section create after Closing the checkpoint designated by checkpointHandle 18 PASSED To verify that section create after finalize Conditions of Submission: ------------------------- Ack from maintainers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
