Summary: ntf: Limit the logger buffer [#2961]
Review request for Ticket(s): 2961
Peer Reviewer(s): Lennart, Minh
Pull request to: Minh
Affected branch(es): develop, release
Development branch: ticket-2961
Base revision: 8679707a45014fc2cb964cd931126a3607a03aab
Personal repository: git://git.code.sf.net/u/canht32/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 2d825d47b278c76fb010fec5380e99b2e6d5f875
Author: Canh Van Truong <canh.v.tru...@dektech.com.au>
Date: Wed, 9 Jan 2019 15:51:41 +0700
ntf: Update TRY_AGAIN error in ntfsend tool [#2961]
ntfsend is blocked in case TRY_AGAIN error. It should do the retry in
limit time.
revision 19ca9bcf42b68044dfabe1bde3a2a992c0e41d88
Author: Canh Van Truong <canh.v.tru...@dektech.com.au>
Date: Wed, 9 Jan 2019 15:51:25 +0700
ntf: Limit the logger buffer [#2961]
When writing the notificaion fail with TRY_AGAIN in callback, the notificaion
is pushed
again to the list. If this happens for long time, the list is going to be very
big.
This cause NTFD take time to process writing all the notification in the list
and
the request from NTFA come this time may be timeout.
The patch does:
- Limit the logger buffer
- Provide the env variable that user can set the value of the limit
- Return TRY_AGAIN error in case the limit of buffer is reached and write
all the
notifications in the buffer to the log file. The current of notification
isn't
written to log file.
Complete diffstat:
------------------
src/ntf/README | 10 ++
src/ntf/ntfd/NtfAdmin.cc | 44 +++++----
src/ntf/ntfd/NtfLogger.cc | 149 ++++++++++++++++------------
src/ntf/ntfd/NtfLogger.h | 11 ++-
src/ntf/ntfd/ntfd.conf | 10 ++
src/ntf/ntfd/ntfs.h | 2 +
src/ntf/tools/ntfclient.c | 75 ++++++++-------
src/ntf/tools/ntfsend.c | 240 +++++++++++++++-------------------------------
8 files changed, 267 insertions(+), 274 deletions(-)
Testing Commands:
-----------------
*** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES ***
Testing, Expected Results:
--------------------------
*** PASTE COMMAND OUTPUTS / TEST RESULTS ***
Conditions of Submission:
-------------------------
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
