Summary: all: fix warnings from gcc 8.2.1 [#2999]
Review request for Ticket(s): 2999
Peer Reviewer(s): Anders, Lennart, Vu, Hans
Pull request to:
Affected branch(es): develop
Development branch: ticket-2999
Base revision: 6c5c389b4d92bf48e42615b067f8a9028880a2a8
Personal repository: git://git.code.sf.net/u/trguitar/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services y
Core libraries n
Samples n
Tests y
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision d7f3be9fbce14611e98b78210d195792ebff83bf
Author: Alex Jones <ajo...@rbbn.com>
Date: Thu, 17 Jan 2019 14:13:25 -0500
logd: fix crash in logd [#2999]
revision 594979358fa946002e22e6a365907b6e2c38fc9b
Author: Alex Jones <ajo...@rbbn.com>
Date: Thu, 17 Jan 2019 14:13:39 -0500
logd: fix truncation warnings [#2999]
revision 7b7f33c8a09ecd68686c5a04ee592226fcfef837
Author: Alex Jones <ajo...@rbbn.com>
Date: Thu, 17 Jan 2019 14:13:34 -0500
log: fix truncation warning [#2999]
revision 2cfda0e8c1ebce0f28e660407f8d8a26f6c8891a
Author: Alex Jones <ajo...@rbbn.com>
Date: Thu, 17 Jan 2019 14:13:25 -0500
smfd: fix uninitialized variable warning [#2999]
revision 1a81955932bff1f4379861fed51404a515099db7
Author: Alex Jones <ajo...@rbbn.com>
Date: Thu, 17 Jan 2019 14:10:33 -0500
all: fix warnings from gcc 8.2.1 [#2999]
These are mostly string overflow issues.
Complete diffstat:
------------------
src/base/conf.cc | 4 +--
src/base/daemon.c | 7 +++--
src/dtm/dtmnd/dtm_main.cc | 2 +-
src/dtm/dtmnd/multicast.cc | 2 +-
src/imm/immnd/immnd_proc.c | 2 +-
src/imm/immnd/immnd_utils.cc | 7 +++--
src/log/apitest/logtestfr.c | 17 ++++++++----
src/log/apitest/saflogtest.c | 7 +++--
src/log/apitest/tet_LogOiOps.c | 56 ++++++++++++++++++++------------------
src/log/apitest/tet_Log_recov.c | 8 +++++-
src/log/apitest/tet_log_longDN.c | 7 +++--
src/log/logd/lgs_dest.cc | 2 +-
src/log/logd/lgs_unixsock_dest.cc | 5 ++--
src/log/logd/lgs_util.cc | 5 ++--
src/mds/mds_c_db.c | 34 +++++++++++++++--------
src/nid/nodeinit.cc | 5 +++-
src/ntf/apitest/tet_ntf_clm.cc | 26 +++++++++++++-----
src/rde/rded/rde_amf.cc | 2 +-
src/smf/smfd/SmfUpgradeCampaign.cc | 2 +-
src/smf/smfd/SmfUpgradeStep.cc | 2 +-
20 files changed, 126 insertions(+), 76 deletions(-)
Testing Commands:
-----------------
run all tests
Testing, Expected Results:
--------------------------
all tests should pass
Conditions of Submission:
-------------------------
Jan 23 or ack from all developers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
-----------------------------------------------------------------------------------------------------------------------
Notice: This e-mail together with any attachments may contain information of
Ribbon Communications Inc. that
is confidential and/or proprietary for the sole use of the intended recipient.
Any review, disclosure, reliance or
distribution by others or forwarding without express permission is strictly
prohibited. If you are not the intended
recipient, please notify the sender immediately and then delete all copies,
including any attachments.
-----------------------------------------------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
