Summary: log: Log enhance to rotate log file via admin operation [#3022] Review request for Ticket(s): 3022 Peer Reviewer(s): Lennart, Vu Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3022 Base revision: ecbdd454813cb2e5994143aa202535374d119392 Personal repository: git://git.code.sf.net/u/canht32/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 1c9e4d8aaabd4df6f3e00b9699a0362fda463ae7 Author: Canh Van Truong <[email protected]> Date: Tue, 16 Apr 2019 14:54:10 +0700 log: Log enhance to rotate log file via admin operation [#3022] In some cases the Users want to rotate log file at the time althouth the file size hasn't been reached MAX FILE SIZE. Log service provides the new feature that user can rotate log file via admin operation. Complete diffstat: ------------------ src/ais/include/saLog.h | 3 +- src/log/apitest/tet_LogOiOps.c | 76 ++++++++++++ src/log/logd/lgs_imm.cc | 258 ++++++++++++++++++++++++----------------- src/log/logd/lgs_mbcsv.cc | 51 ++++++-- src/log/logd/lgs_stream.cc | 153 ++++++++++++------------ src/log/logd/lgs_stream.h | 3 + 6 files changed, 342 insertions(+), 202 deletions(-) Testing Commands: ----------------- Add 2 more test cases: logtest 6 47 logtest 6 48 Testing, Expected Results: -------------------------- all test cases passed Conditions of Submission: ------------------------- Ack from reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
