Summary: amfnd: reboot to recovery if msg id received by amfd mismatch with msg
id sent by amfnd [#3040]
Review request for Ticket(s): 3040
Peer Reviewer(s): Gary, Hans, Minh
Pull request to: Gary
Affected branch(es): develop
Development branch: ticket-3040
Base revision: 55466efcacc6d83f104ee747ebc189688ccc2de1
Personal repository: git://git.code.sf.net/u/thangng/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
revision f8bb951980532726a91a158efd6bb2b9452c70e4
Author: thang.d.nguyen <thang.d.ngu...@dektech.com.au>
Date: Tue, 14 May 2019 20:48:06 +0700
amfnd: reboot to recovery if msg id received by amfd mismatch with msg id sent
by amfnd [#3040]
During SC failover, message received on ACTIVE AMFD
can not be checked point to AMFD on STANDBY SC.
But the AMFND still process the message ack for that
message then it remove from queue.
STANDBY SC takes ACTIVE and mismatch message id b/w
AMFD and AMFND on new ACTIVE. As consequence,
clm track start can not invoked to update cluster
member nodes if these nodes was rebooted.
In this case, amfnd need rebooting automatically to
recovery it.
Complete diffstat:
------------------
src/amf/amfnd/verify.cc | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
Testing Commands:
-----------------
N/A
Testing, Expected Results:
--------------------------
N/A
Conditions of Submission:
-------------------------
Acked from reviewer
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
