Summary: mds: Add solution for TIPC buffer overflow at MDS [#1960]
Review request for Ticket(s): 1960
Peer Reviewer(s): Anders, HansN, Lennart, Gary, Vu, Thuan
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-1960
Base revision: 2d85d5d9264c6a7d1c6601b900fb810facbee3ac
Personal repository: git://git.code.sf.net/u/minh-chau/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries y
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
Sending on behalf of Thuan & Minh.
Some pending tasks to accomplish
. Handle broadcast/multicast mds message with flow control.
. Reduce the memory re-allocation overhead if enables flow control.
(At this moment, memory is allocated at mds_dt_tip.c and cloned to buffer
for retransmission queue again).
. The sequence number arithmetic (sna) should be implemented in /base code.
. Adding mdstest to cover sna wrapped-round
. MDS_CHECKSUM_ENABLE_FLAG
revision d208cff344c35afd25ac01ab4f9057d153fe9495
Author: Minh Chau <minh.c...@dektech.com.au>
Date: Wed, 14 Aug 2019 16:22:12 +1000
mds: Add TIPC buffer overflow for mdstest [#1960]
(Sending on behalf of Thuan)
revision d04c3e99744b86278c6a54d8ec1e4caabfbcabd2
Author: Minh Chau <minh.c...@dektech.com.au>
Date: Wed, 14 Aug 2019 16:22:12 +1000
mds: Apply serial number arithmetic for sequence counter [#1960]
This patch applies the serial number arithmetic for the flow control
sequence number, referenced to RFC1982.
This is only temporary patch, a proper one could be made in /base
with template for others type, e.g uint32. Then mds reuses it from
/base.
revision 7bbaf4eed324ba0575f4893a37eb10c9b7df4426
Author: Minh Chau <minh.c...@dektech.com.au>
Date: Wed, 14 Aug 2019 16:22:12 +1000
mds: Add configurable parameters [#1960]
This patch makes the solution of TIPC buffer overflow configurable,
as well as the ack timeout/ack size.
For example:
The service config file can export the following environment variables
export MDS_TIPC_FCTRL_ENABLED=1
export MDS_TIPC_FCTRL_ACKTIMEOUT=1000
export MDS_TIPC_FCTRL_ACKSIZE=1
If MDS_TIPC_FCTRL_ACKTIMEOUT, MDS_TIPC_FCTRL_ACKSIZE are not specified,
the default values are used.
revision 842dcecbdbafb3744a99ead42899f955eb79f94f
Author: Minh Chau <minh.c...@dektech.com.au>
Date: Wed, 14 Aug 2019 16:22:12 +1000
mds: Implement kRcvBuffOverflow state [#1960]
This patch implements the kRcvBuffOverflow state machine as
described in README file.
revision ed03d11a194f9775fc43003acc35924ef28227b7
Author: Minh Chau <minh.c...@dektech.com.au>
Date: Wed, 14 Aug 2019 16:22:12 +1000
mds: Add state machine for tipc portid instance [#1960]
This patch adds state machine to support tx probation timer.
revision 759f7ef7b55a8f27118e82c757c21b2f452c8b7c
Author: Minh Chau <minh.c...@dektech.com.au>
Date: Wed, 14 Aug 2019 16:22:12 +1000
mds: Add timeout for ack message [#1960]
If the ack size is configured greater than 1, there should be a timeout
at receiver ends to send the ack message back to senders.
The ack message timeout utilizes the poll timeout in flow control thread
to make mds lightweight (in contrast to additional timer threads).
revision 7c115e411f9de31b2ffe3c32ed401d7b8a3de696
Author: Minh Chau <minh.c...@dektech.com.au>
Date: Wed, 14 Aug 2019 16:21:33 +1000
mds: Add implementation for TIPC buffer overflow solution [#1960]
This is a collaborative patch of two participants:Thuan, Minh.
Main changes:
- Add mds_tipc_fctrl_intf.h, mds_tipc_fctrl_intf.cc: These two files
introduce new functions which are called in mds_dt_tipc.c if the flow
control is enabled
- Add mds_tipc_fctrl_portid.h, mds_tipc_fctrl_portid.cc: These files
implements the tipc portid instance, which supports the sliding window,
mds msg queue
- Add mds_tipc_fctrl_msg.h, mds_tipc_fctrl_msg.cc: These files define
the event and messages which are used for this solution.
revision 4096f66de92f89ef30a54a137465384b74143800
Author: Minh Chau <minh.c...@dektech.com.au>
Date: Wed, 14 Aug 2019 16:12:19 +1000
mds: Resolve c/c++ linking issue [#1960]
(Sending on behalf of Thuan)
This patch solves the linking issue if mds_dt.h or mds_core.h
is included in c++ sources.
revision 04152d708f30abf813dad1c18d5ed3d73df4ef3d
Author: Minh Chau <minh.c...@dektech.com.au>
Date: Wed, 14 Aug 2019 16:11:17 +1000
mds: Add README for solution of TIPC buffer overflow at MDS [#1960]
Added Files:
------------
src/mds/mds_tipc_fctrl_intf.cc
src/mds/mds_tipc_fctrl_intf.h
src/mds/mds_tipc_fctrl_msg.cc
src/mds/mds_tipc_fctrl_msg.h
src/mds/mds_tipc_fctrl_portid.cc
src/mds/mds_tipc_fctrl_portid.h
src/mds/README
Complete diffstat:
------------------
src/mds/Makefile.am | 10 +-
src/mds/README | 221 ++++++++++++++++++
src/mds/apitest/mdstest.c | 5 +-
src/mds/apitest/mdstipc.h | 6 +-
src/mds/apitest/mdstipc_api.c | 237 +++++++++++++++++++
src/mds/apitest/mdstipc_conf.c | 19 +-
src/mds/mds_core.h | 74 ++++++
src/mds/mds_dt.h | 12 +-
src/mds/mds_dt2c.h | 67 ------
src/mds/mds_dt_tcp.c | 2 +
src/mds/mds_dt_tcp.h | 1 -
src/mds/mds_dt_tipc.c | 203 +++++++++++-----
src/mds/mds_tipc_fctrl_intf.cc | 467 ++++++++++++++++++++++++++++++++++++
src/mds/mds_tipc_fctrl_intf.h | 48 ++++
src/mds/mds_tipc_fctrl_msg.cc | 142 +++++++++++
src/mds/mds_tipc_fctrl_msg.h | 137 +++++++++++
src/mds/mds_tipc_fctrl_portid.cc | 493 +++++++++++++++++++++++++++++++++++++++
src/mds/mds_tipc_fctrl_portid.h | 176 ++++++++++++++
18 files changed, 2172 insertions(+), 148 deletions(-)
Testing Commands:
-----------------
all service's legacy apitest testcases
mdstest 27
Testing, Expected Results:
--------------------------
all pass
Conditions of Submission:
-------------------------
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
