Re: [devel] [PATCH 1/1] mbc: fix some coding errors [#3070]

[Gary Lee]

Hi Thuan

ack (review only)

Thanks

Gary

On 14/8/19 8:24 pm, thuan.tran wrote:

---
  src/mbc/mbcsv_api.c  | 6 +++---
  src/mbc/mbcsv_peer.c | 2 +-
  2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/mbc/mbcsv_api.c b/src/mbc/mbcsv_api.c
index 84a2b8771..3a84fdfda 100644
--- a/src/mbc/mbcsv_api.c
+++ b/src/mbc/mbcsv_api.c
@@ -619,7 +619,7 @@ uint32_t mbcsv_process_close_request(NCS_MBCSV_ARG *arg)
        if (NULL ==
            (mbc_reg = (MBCSV_REG *)m_MBCSV_TAKE_HANDLE(arg->i_mbcsv_hdl))) {
                TRACE_2("bad handle specified");
-               rc = SA_AIS_ERR_BAD_HANDLE;
+               return SA_AIS_ERR_BAD_HANDLE;
        }

m_NCS_LOCK(&mbc_reg->svc_lock, NCS_LOCK_WRITE);

@@ -685,7 +685,7 @@ uint32_t mbcsv_process_chg_role_request(NCS_MBCSV_ARG *arg)
        if (NULL ==
            (mbc_reg = (MBCSV_REG *)m_MBCSV_TAKE_HANDLE(arg->i_mbcsv_hdl))) {
                TRACE_2("bad handle specified");
-               rc = SA_AIS_ERR_BAD_HANDLE;
+               return SA_AIS_ERR_BAD_HANDLE;
        }

m_NCS_LOCK(&mbc_reg->svc_lock, NCS_LOCK_READ);

@@ -804,7 +804,7 @@ uint32_t mbcsv_process_snd_ckpt_request(NCS_MBCSV_ARG *arg)
        if (NULL ==
            (mbc_reg = (MBCSV_REG *)m_MBCSV_TAKE_HANDLE(arg->i_mbcsv_hdl))) {
                TRACE_2("bad handle specified");
-               rc = SA_AIS_ERR_BAD_HANDLE;
+               return SA_AIS_ERR_BAD_HANDLE;
        }

m_NCS_LOCK(&mbc_reg->svc_lock, NCS_LOCK_READ);

diff --git a/src/mbc/mbcsv_peer.c b/src/mbc/mbcsv_peer.c
index 1d4b257a3..1a9eeb125 100644
--- a/src/mbc/mbcsv_peer.c
+++ b/src/mbc/mbcsv_peer.c
@@ -54,7 +54,7 @@ the messages received from the peer.

static const char *disc_trace[] = {"Peer UP msg", "Peer DOWN msg",

                                   "Peer INFO msg", "Peer INFO resp msg",
-                                  "Peer Role change msg"
+                                  "Peer Role change msg",
                                   "Invalid peer discovery msg"};
  typedef enum {ANCHOR_SEARCH, NODE_ID_SEARCH} SearchMode;

_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel