Hi Minh, ACK from me.
Best Regards, ThuanTr -----Original Message----- From: Minh Hon Chau <minh.c...@dektech.com.au> Sent: Monday, October 7, 2019 7:12 AM To: hans.nordeb...@ericsson.com; vu.m.ngu...@dektech.com.au; gary....@dektech.com.au; thuan.t...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 0/2] Review Request for mds: Add Nack message for MDS_TIPC_FCTRL_ENABLED [#3095] V2 Hi, I would like to push the patches today if no more comment for them. Thanks Minh On 4/10/19 3:20 pm, Minh Chau wrote: > Summary: mds: Add Nack message for MDS_TIPC_FCTRL_ENABLED [#3095] V2 > Review request for Ticket(s): 3095 Peer Reviewer(s): Hans, Vu, Gary, > Thuan Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** > Affected branch(es): develop Development branch: ticket-3095 Base > revision: 05064a1cfd0aeaf824dce7602d535654b3457e30 > Personal repository: git://git.code.sf.net/u/minh-chau/review > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services n > OpenSAF services n > Core libraries y > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** > > revision cbbeab8f2299620aa3eb9b0e29710a2b159b5a45 > Author: Minh Chau <minh.c...@dektech.com.au> > Date: Fri, 4 Oct 2019 12:59:27 +1000 > > mds: Improve error log for MDS_TIPC_FCTRL_ENABLED [#3095] > > This commit as part of #3095 updates the error string with pattern > "FCTRL:*Error[*]", in order to help grep-ing the error in mds debug > log. > > > > revision cc666586717fa82df70471748d8766e8fe901460 > Author: Minh Chau <minh.c...@dektech.com.au> > Date: Fri, 4 Oct 2019 12:59:16 +1000 > > mds: Add Nack message for MDS_TIPC_FCTRL_ENABLED [#3095] > > In the scenario of recovery from split-brain, where both active > director services may suffer mds message loss due to lost-contact tipc > link. If MDS_TIPC_FCTRL_ENABLED is set, the out-of-order message will > be dropped, and there is no mechanism to trigger the retransmission > from receiver side at this moment (the retransmission is only > triggered from sender as result of TIPC_ERR_OVERLOAD). > > In reception of disordered message, the receiver can send > not-acknowledgement to notify the sender for retransmission. > Therefore, the sender can trigger retransmisison in the same way as > receiving TIPC_ERR_OVERLOAD. > > This patch adds Nack message for retransmission of disordered message > detected from receiver side, and adds a missing call to > portid_map_mutex.unlock() in process_all_events(). > > > > Complete diffstat: > ------------------ > src/mds/mds_c_api.c | 2 +- > src/mds/mds_dt_common.c | 2 +- > src/mds/mds_tipc_fctrl_intf.cc | 72 > +++++++++++++++++++++++++++++----------- > src/mds/mds_tipc_fctrl_msg.cc | 35 ++++++++++++++++++- > src/mds/mds_tipc_fctrl_msg.h | 22 ++++++++++++ > src/mds/mds_tipc_fctrl_portid.cc | 42 ++++++++++++++++------- > src/mds/mds_tipc_fctrl_portid.h | 3 +- > 7 files changed, 143 insertions(+), 35 deletions(-) > > > Testing Commands: > ----------------- > *** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES *** > > > Testing, Expected Results: > -------------------------- > *** PASTE COMMAND OUTPUTS / TEST RESULTS *** > > > Conditions of Submission: > ------------------------- > *** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC *** > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any > checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, > user.email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel