Hi,
There is a issue with this change, I need consider more.
Please ignore this review for now.
Best Regards,
ThuanTr
-----Original Message-----
From: thuan.tran <thuan.t...@dektech.com.au>
Sent: Thursday, October 17, 2019 4:56 PM
To: 'Minh Chau' <minh.c...@dektech.com.au>; hans.nordeb...@ericsson.com;
gary....@dektech.com.au; vu.m.ngu...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net; thuan.tran
<thuan.t...@dektech.com.au>
Subject: [PATCH 1/1] mds: not waste 1.5s in waiting Adest already down to
send response message [#3102]
- When sending response message which Adest not exist (already down) current
MDS try to waiting in 1.5 seconds before conclude no route to send response
message.
- With this change, MDS will not waste for 1.5s which can cause trouble for
higher layer services, e.g: ntf, imm, etc...
---
src/mds/mds_c_sndrcv.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/mds/mds_c_sndrcv.c b/src/mds/mds_c_sndrcv.c index
7850ac714..f0c60a8b7 100644
--- a/src/mds/mds_c_sndrcv.c
+++ b/src/mds/mds_c_sndrcv.c
@@ -2713,17 +2713,17 @@ static uint32_t
mds_mcm_process_disc_queue_checks_redundant(
"MDS_SND_RCV: Subscription made but no pointer
available\n");
return NCSCC_RC_FAILURE;
}
- } else if (sub_info->tmr_flag != true) {
- if ((MDS_SENDTYPE_RSP == req->i_sendtype) ||
- (MDS_SENDTYPE_RRSP == req->i_sendtype)) {
+ } else if (sub_info->tmr_flag == true) {
+ if (((MDS_SENDTYPE_RSP == req->i_sendtype) ||
+ (MDS_SENDTYPE_RRSP == req->i_sendtype))) {
time_wait = true;
m_MDS_LOG_INFO(
- "MDS_SND_RCV:Disc queue red: Subscr exists no
timer running: Waiting for some time\n");
- } else {
- m_MDS_LOG_INFO(
- "MDS_SND_RCV: Subscription exists but Timer has
expired\n");
- return NCSCC_RC_FAILURE;
+ "MDS_SND_RCV:Disc queue red: Subscr exists timer
running:
+Waiting for some time\n");
}
+ } else {
+ m_MDS_LOG_INFO(
+ "MDS_SND_RCV: Subscription exists but Timer has
expired\n");
+ return NCSCC_RC_FAILURE;
}
/* Add this message to the DISC Queue, One function call */
--
2.17.1
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
