Hi Vu, Agree, please help update NULL to nullptr before push. Thanks.
Best Regards, ThuanTr -----Original Message----- From: Nguyen Minh Vu <vu.m.ngu...@dektech.com.au> Sent: Tuesday, November 19, 2019 9:58 AM To: thuan.tran <thuan.t...@dektech.com.au>; 'Minh Hon Chau' <minh.c...@dektech.com.au>; gary....@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1/1] log: Fix coding issues identified by codechecker [#3113] Hi Thuan, Ack with a minor comment. Regards, Vu On 11/4/19 2:17 PM, thuan.tran wrote: > --- > src/log/logd/lgs_mbcsv.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/log/logd/lgs_mbcsv.cc b/src/log/logd/lgs_mbcsv.cc > index cd3d70009..ebc659ea1 100644 > --- a/src/log/logd/lgs_mbcsv.cc > +++ b/src/log/logd/lgs_mbcsv.cc > @@ -1931,7 +1931,7 @@ static uint32_t ckpt_proc_log_write(lgs_cb_t *cb, void > *data) { > /* If configured for split file system log records shall be written also > if > * we are standby. > */ > - if (lgs_is_split_file_system()) { > + if (lgs_is_split_file_system() && (logRecord != NULL)) { [Vu] Prefer using nullptr to NULL > size_t rec_len = strlen(logRecord); > stream->act_last_close_timestamp = c_file_close_time_stamp; > _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel