Hi Minh, No more comment from me. Thanks.
Best Regards, ThuanTr -----Original Message----- From: Minh Hon Chau <minh.c...@dektech.com.au> Sent: Tuesday, December 3, 2019 12:53 PM To: thuan.t...@dektech.com.au; vu.m.ngu...@dektech.com.au; gary....@dektech.com.au; hans.nordeb...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 0/2] Review Request for mds: Avoid message reallocation [#3089] V3 Hi Vu, Thuan Any comments on the patches. Thanks Minh On 28/11/19 10:54 pm, Minh Chau wrote: > Summary: mds: Avoid message reallocation [#3089] > Review request for Ticket(s): 3089 > Peer Reviewer(s): Thuan, Vu, Gary > Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** > Affected branch(es): develop > Development branch: ticket-3089 > Base revision: 8e07c19aed63c249f4e7fa8470270d2de1a56046 > Personal repository: git://git.code.sf.net/u/minh-chau/review > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services n > OpenSAF services n > Core libraries y > Samples n > Tests n > Other n > > NOTE: Patch(es) contain lines longer than 80 characers > > Comments (indicate scope for each "y" above): > --------------------------------------------- > *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** > > revision d3bdf53e99523785cdc932d62b25267ea900c643 > Author: Minh Chau <minh.c...@dektech.com.au> > Date: Thu, 28 Nov 2019 21:08:50 +1100 > > mds: Avoid message reallocation [#3089] > > The patch avoids message reallocation if the message is in > retransmission queue > > > > revision 7be0f5404ebb8ec5b8752813899d6aefd1ef6c33 > Author: Minh Chau <minh.c...@dektech.com.au> > Date: Thu, 28 Nov 2019 21:08:38 +1100 > > mds: Improve readibility [#3089] > > Correct indent and reduce code lines (<80 chars) for > mds_mdtm_send_tipc() and mdtm_frag_and_send() > > > > Complete diffstat: > ------------------ > src/mds/mds_dt_tipc.c | 534 > +++++++++++++++++++++------------------ > src/mds/mds_tipc_fctrl_intf.cc | 6 +- > src/mds/mds_tipc_fctrl_intf.h | 4 +- > src/mds/mds_tipc_fctrl_msg.cc | 2 +- > src/mds/mds_tipc_fctrl_portid.cc | 9 +- > 5 files changed, 294 insertions(+), 261 deletions(-) > > > Testing Commands: > ----------------- > *** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES *** > > > Testing, Expected Results: > -------------------------- > *** PASTE COMMAND OUTPUTS / TEST RESULTS *** > > > Conditions of Submission: > ------------------------- > *** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC *** > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email > etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
