Summary: log: make fixed facility ID configurable [#3131]
Review request for Ticket(s): 3131
Peer Reviewer(s): Vu
Pull request to: Vu
Affected branch(es): develop
Development branch: ticket-3131
Base revision: 740100f2ebfb5458a8052dea29b5583b3dc8df5a
Personal repository: git://git.code.sf.net/u/thienhuynh/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 286893254d377ad13f4839d75666e29289d5e190
Author: thien.m.huynh <thien.m.hu...@dektech.com.au>
Date: Wed, 15 Jan 2020 17:57:09 +0700
log: make fixed facility ID configurable [#3131]
Configure facility id via a new attribute `saLogStreamFacilityId`.
The default value is 16 to keep the streaming feature backward compatible.
Adding 05 new test case into a new testsuite 22:
- Test configuring `saLogStreamFacilityId`.
- Verify if PRI field in package RFC5424 equals to
(saLogStreamFacilityId * 8 + severity).
Update README file.
Added Files:
------------
src/log/apitest/log_server.cc
src/log/apitest/log_server.h
src/log/apitest/tet_saLogStreamConfigFacilityId.c
src/log/logd/lgs_mbcsv_v9.cc
src/log/logd/lgs_mbcsv_v9.h
Complete diffstat:
------------------
.../implementer/test_saImmOiRtObjectCreate_2.c | 9 +-
.../implementer/test_saImmOiRtObjectDelete.c | 4 +-
.../implementer/test_saImmOiRtObjectUpdate_2.c | 4 +-
src/log/Makefile.am | 9 +-
src/log/README | 19 +-
src/log/apitest/log_server.cc | 47 ++++
src/log/apitest/log_server.h | 35 +++
src/log/apitest/tet_saLogStreamConfigFacilityId.c | 279 +++++++++++++++++++++
src/log/config/logsv_classes.xml | 14 ++
src/log/logd/lgs_cache.cc | 1 +
src/log/logd/lgs_dest.cc | 1 +
src/log/logd/lgs_dest.h | 6 +-
src/log/logd/lgs_imm.cc | 74 +++++-
src/log/logd/lgs_mbcsv.cc | 187 +++++++++++++-
src/log/logd/lgs_mbcsv.h | 5 +-
src/log/logd/lgs_mbcsv_v9.cc | 243 ++++++++++++++++++
src/log/logd/lgs_mbcsv_v9.h | 67 +++++
src/log/logd/lgs_recov.cc | 10 +
src/log/logd/lgs_stream.cc | 9 +
src/log/logd/lgs_stream.h | 1 +
src/log/logd/lgs_unixsock_dest.cc | 7 +-
src/log/tests/lgs_dest_test.cc | 3 +
22 files changed, 1009 insertions(+), 25 deletions(-)
Testing Commands:
-----------------
N/A
Testing, Expected Results:
--------------------------
N/A
Conditions of Submission:
-------------------------
ACK from reviewer
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
